reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dhruv Mahajan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (REEF-1361) IFileDeSerializer does not have a Dispose function
Date Wed, 27 Apr 2016 17:49:12 GMT

    [ https://issues.apache.org/jira/browse/REEF-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15260587#comment-15260587
] 

Dhruv Mahajan commented on REEF-1361:
-------------------------------------

Consider the case where the input files to DeSerializer are in non-compressed format and we
want to convert it in to some compressed binary format after parsing and all... In this case
I will take these files, apply parsing and write in compressed binary format and then use
it to create PartitionHandle in {{FileSystemInputPartition}}. Now when we are disposing {{FileSystemInputPartition}}
I would like to delete these files. However, after REEF-1357 all this will be done as part
of Cache class and {{FileSystemInputPartition}} will be refactored there. So I have two possibilities
- either make this small transient change, or in my current application where I require above
functionality, not delete the file for the time being since it is in any case written to the
reef runtime folder of container.

> IFileDeSerializer does not have a Dispose function
> --------------------------------------------------
>
>                 Key: REEF-1361
>                 URL: https://issues.apache.org/jira/browse/REEF-1361
>             Project: REEF
>          Issue Type: Improvement
>          Components: REEF.NET IO
>         Environment: C#
>            Reporter: Dhruv Mahajan
>
> Currently {{IFileDeserializer}} does not inherit {{IDisposable}} class to dispose unmanaged
resources like files. This becomes necessary in case it decides to add some disk based cache
and writes a cache to the disk at some temporary location. This cache then needs to be deleted
once {{IInputPartition}} is being disposed by calling the {{IFileDeserializer.Dispose()}}
in {{IInputPartition.Dispose()}}.
> The aim of this JIRA is to introduce the dispose functionality in  {{IFileDeserializer}}
and modify {{FileSystemInputPartition}} to use it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message