reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Markus Weimer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (REEF-1352) Add exception classes for integration tests
Date Fri, 22 Apr 2016 22:28:17 GMT

    [ https://issues.apache.org/jira/browse/REEF-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15254811#comment-15254811
] 

Markus Weimer commented on REEF-1352:
-------------------------------------

Hmm, good question. That depends on how it is used, in a way. If it is used to test the exception
handling in a running applications (in the chaos monkey sense), it shouldn't be expected,
right?

> Add exception classes for integration tests
> -------------------------------------------
>
>                 Key: REEF-1352
>                 URL: https://issues.apache.org/jira/browse/REEF-1352
>             Project: REEF
>          Issue Type: New Feature
>          Components: REEF.NET
>            Reporter: Markus Weimer
>
> We currently rely on ad-hoc exception messages in the REEF.NET integration tests. Once
the work to properly propagate exceptions from Evaluator to Driver to Client is done, we can
do better than that. Namely, I propose to introduce a set of new exception types in the {{Org.Apache.REEF.Tests.Exceptions}}
namespace:
> *Expected Exceptions*
>   * {{DriverSideExpectedException}}: The test expects this exception and will check its
contents (cause, message) to decide whether the test passes.
>   * {{EvaluatorSideExpectedException}}: Same, but on the driver side.
> *Exceptions indicating test failure*
>   * {{DriverSideTestFailure}}: The test failed because of a check on the Driver side.
>   * {{EvaluatorSideTestFailure}}: Same, but on the driver side.
> *Exceptions indicating bugs in untested parts of REEF*
>   * {{DriverSideSystemException}}: The test encountered unexpected behavior that it didn't
test for. In other words: A change broke the test.
>   * {{EvaluatorSideSystemException}}: Same, but on the driver side.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message