reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Markus Weimer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (REEF-1243) Fix StreamingRemoteManagerTest tests which get stuck in AppVeyor
Date Fri, 22 Apr 2016 19:48:12 GMT

    [ https://issues.apache.org/jira/browse/REEF-1243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15254536#comment-15254536
] 

Markus Weimer commented on REEF-1243:
-------------------------------------

Some comments on the test itself:

Many of the tests contain code like the one found in lines 52 and 53:
{code}
IPEndPoint endpoint1 = new IPEndPoint(listeningAddress, 0);
remoteManager2.RegisterObserver(endpoint1, observer);
{code}

This assumes that the endpoint can actually be opened, right? Maybe we should check that it
worked.

The code that follows also assumes that communications on {{127.0.0.1}} actually work, which
might not be the case on the build machines. We might need some exception handling that skips
the test if we can't open or connect to ports.

The .NET API has specific support for the loopback device. Hence {{IPAddress listeningAddress
= IPAddress.Parse("127.0.0.1");}} should be replaced with {{IPAddress listeningAddress = IPAddress.Loopback;}}.
I don't think that actually changes anything, it is more for code cleanliness.

> Fix StreamingRemoteManagerTest tests which get stuck in AppVeyor
> ----------------------------------------------------------------
>
>                 Key: REEF-1243
>                 URL: https://issues.apache.org/jira/browse/REEF-1243
>             Project: REEF
>          Issue Type: Sub-task
>          Components: REEF.NET
>            Reporter: Mariia Mykhailova
>            Assignee: Dhruv Mahajan
>
> AppVeyor test runs get stuck on tests from {{StreamingRemoteManagerTest}} group:
> * https://ci.appveyor.com/project/ApacheSoftwareFoundation/reef/build/11-master/tests
- stuck on {{TestStreamingRegisterObserverByType}}
> * https://ci.appveyor.com/project/ApacheSoftwareFoundation/reef/build/13-master/tests
- stuck on {{TestStreamingCommunicationThreeNodesBoth}}
> * https://ci.appveyor.com/project/tcNickolas/reef/build/0.14.0-SNAPSHOT.25-APPVEYOR_EXP/tests
- stuck on {{TestStreamingCachedConnection}}
> I can't repro this locally. We need to investigate and fix this.
> To repro this on AppVeyor, one can add their mirror of reef to AppVeyor projects (https://ci.appveyor.com/projects/new
after you're logged in with your GitHub account), and then everything pushed to any branch
in the mirror gets executed in AppVeyor with the same settings as on main reef. It is possible
to limit the scope of tests executed by modifying {{test_script}} section. For example, to
run only O.A.R.Tests change it to:
> {noformat}
> test_script:
>   - cd .\lang\cs
>   - cmd: .\packages\xunit.runner.console.2.1.0\tools\xunit.console.exe .\bin\x64\Debug\Org.Apache.REEF.Tests\Org.Apache.REEF.Tests.dll
> {noformat}
> I haven't found a way to access machine on which tests are run directly, only via scripts
added to {{appveyor.yml}}.
> This change should also include reverting REEF-1311 (including {{StreamingRemoteManagerTest}}
tests to AppVeyor coverage again).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message