reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Markus Weimer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (REEF-1069) Revisit IClock/RuntimeClock
Date Thu, 28 Apr 2016 22:13:12 GMT

    [ https://issues.apache.org/jira/browse/REEF-1069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15263133#comment-15263133
] 

Markus Weimer commented on REEF-1069:
-------------------------------------

The {{public}} methods in {{RuntimeClock}} which aren't in {{IClock}} are:

{code}
public void RegisterObserver<U>(IObserver<U> observer) where U : Time;
public void Run();
{code}

{{RegisterObserver}} is never called. hence, I suggest to drop it. {{Run}} should be added
to {{IClock}}. With both these changes in effect, we can resolve this situation.

> Revisit IClock/RuntimeClock
> ---------------------------
>
>                 Key: REEF-1069
>                 URL: https://issues.apache.org/jira/browse/REEF-1069
>             Project: REEF
>          Issue Type: Improvement
>          Components: REEF.NET
>            Reporter: Julia
>
> Currently in .Net several public methods are not define at IClock level but RuntimeClock,
that enforces the code to use subclass instead of interface/abstract class. 
> For example, in EvaluatorSettings, we have to inject RuntimeClock instead of IClock.

> Once the proper methods are defined at base level, we should then change  RuntimeClock
into IClock in EvaluatorSettings constructor and set RuntimeClock as a default implementation
of IClock. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message