reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Byung-Gon Chun <bgc...@gmail.com>
Subject Re: Exception numbering?
Date Tue, 19 Apr 2016 23:17:06 GMT
(2) sounds good.

Do we have multiple log lines for an exception in REEF.NET? Why is it
different from REEF Java?



On Wed, Apr 20, 2016 at 5:30 AM, Markus Weimer <markus@weimo.de> wrote:

> Hi,
>
> over on dev@spark, a nice way to make exception printouts more readable
> was proposed:
>
> On 4/18/2016 12:16 PM, Reynold Xin wrote to dev@spark.apache.org:
>
>> (1) Create a common root class for all the exceptions (e.g. call it
>> SparkException) used in Spark. We should make sure every time we
>> catch an exception from a 3rd party library, we rethrow them as
>> SparkException (a lot of places already do that). In
>> SparkException's constructor, log the exception and the stacktrace.
>>
>> (2) SparkException has a monotonically increasing ID, and this ID
>> appears in the exception error message (say at the end).
>>
>
>
> I really like the second part of it. We currently log exactly once on the
> Java side and way more often on the .NET side. Hence, I don't think we need
> to concern ourselves with the logging of the exceptions.
>
> However, the numeric ID would be very useful, especially for REEF.NET
> where each exception is logged more than once.
>
> What do you think?
>
> Markus
>



-- 
Byung-Gon Chun

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message