reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Julia (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (REEF-1232) Fix binding in TaskConfiguration for ITaskMessageSource
Date Thu, 03 Mar 2016 01:09:18 GMT

     [ https://issues.apache.org/jira/browse/REEF-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Julia updated REEF-1232:
------------------------
    Description: 
Currently in TaskConfiguration we bind 
.BindImplementation(GenericType<ITaskMessageSource>.Class, OnSendMessage)
While in TaskStatus at evaluator side, we are expecting [Parameter(typeof(TaskConfigurationOptions.TaskMessageSources))]
ISet<ITaskMessageSource> taskMessageSources,
This results in whatever implementation set at driver side won't be injected at task side.
We need to fix it in TaskConfiguration to use ISet<>.

Currently TestTaskMessage doesn't really verify the messages send/received between driver
and task. We need to enhance the tests to validate the messages. That would also allow us
to find any issues through the tests. 

  was:
Currently TestTaskMessage doesn't really verify the messages send/received between driver
and task. We need to enhance the tests to validate the messages. That would also allow us
to find any issues through the tests. 

The fix for TaskConfgiuration will be in a separate JIRA. 


> Fix binding in TaskConfiguration for ITaskMessageSource
> -------------------------------------------------------
>
>                 Key: REEF-1232
>                 URL: https://issues.apache.org/jira/browse/REEF-1232
>             Project: REEF
>          Issue Type: Bug
>            Reporter: Julia
>            Assignee: Julia
>
> Currently in TaskConfiguration we bind 
> .BindImplementation(GenericType<ITaskMessageSource>.Class, OnSendMessage)
> While in TaskStatus at evaluator side, we are expecting [Parameter(typeof(TaskConfigurationOptions.TaskMessageSources))]
ISet<ITaskMessageSource> taskMessageSources,
> This results in whatever implementation set at driver side won't be injected at task
side.
> We need to fix it in TaskConfiguration to use ISet<>.
> Currently TestTaskMessage doesn't really verify the messages send/received between driver
and task. We need to enhance the tests to validate the messages. That would also allow us
to find any issues through the tests. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message