reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Markus Weimer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (REEF-1232) Fix binding in TaskConfiguration for ITaskMessageSource
Date Wed, 02 Mar 2016 23:43:18 GMT

    [ https://issues.apache.org/jira/browse/REEF-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176725#comment-15176725
] 

Markus Weimer commented on REEF-1232:
-------------------------------------

So, the fix is to replace line 97 of {{TaskConfiguration}}:

{code}
.BindImplementation(GenericType<ITaskMessageSource>.Class, OnSendMessage)
{code}

with:

{code}
.BindSetEntry(GenericType<TaskConfigurationOptions.TaskMessageSources>.Class, OnSendMessage)
{code}

right?

> Fix binding in TaskConfiguration for ITaskMessageSource
> -------------------------------------------------------
>
>                 Key: REEF-1232
>                 URL: https://issues.apache.org/jira/browse/REEF-1232
>             Project: REEF
>          Issue Type: Bug
>            Reporter: Julia
>
> Currently in TaskConfiguration we bind 
> .BindImplementation(GenericType<ITaskMessageSource>.Class, OnSendMessage)
> While in TaskStatus at evaluator side, we are expecting   [Parameter(typeof(TaskConfigurationOptions.TaskMessageSources))]
ISet<ITaskMessageSource> taskMessageSources,
> This results in whatever implementation set at driver side won't be injected at task
side. 
> We need to fix it in TaskConfiguration to use ISet<>. And enhance the test cases
to detect such issue. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message