reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mariia Mykhailova <mamyk...@microsoft.com>
Subject RE: [VOTE] Documentation commits without code review
Date Wed, 16 Mar 2016 22:14:08 GMT
+1

To clarify, I think any code which is not part of REEF itself (for example, scripts in dev
folder and JavaScript in website) still should be reviewed.
Major changes (for example, what I suggest in REEF-1252) should probably also be reviewed.
CI configuration files (Travis/AppVeyor) are gray area, they are not code but not documentation
either.

@Dongjoon
I think the suggestion is to make reviews optional, not to prohibit them altogether - if the
author of the change feels it needs to be double-checked, they still can send a PR, just without
JIRA.

-Mariia

-----Original Message-----
From: Dongjoon Hyun [mailto:dongjoon@apache.org] 
Sent: Tuesday, March 15, 2016 4:27 PM
To: dev@reef.apache.org
Subject: Re: [VOTE] Documentation commits without code review

+0

I think PR should be a minimum requirement since I make mistakes sometime and I like to be
reviewed. :) However, if the community want, I have no objection.

On Tue, Mar 15, 2016 at 4:21 PM, Anupam <anupam128@gmail.com> wrote:

> +1
>
> I thought this should have been subsumed by the [MINOR] tag we agreed on.
>
> On 15 March 2016 at 15:52, Byung-Gon Chun <bgchun@gmail.com> wrote:
> > +1
> >
> > On Wed, Mar 16, 2016 at 7:42 AM, Markus Weimer <markus@weimo.de> wrote:
> >
> >> +1
> >>
> >> (and fixed the subject :-) )
> >>
> >> Markus
> >>
> >> On 2016-03-15 15:38, Markus Weimer wrote:
> >> > Based on our recent discussion, I'd like to call the following vote:
> >> >
> >> > Allow [Documentation] commits: These are commits that only change 
> >> > non-code files (README, website, ...). For these, the JIRA and 
> >> > Pull Request process shall be optional.
> >> >
> >> > Instead, it is up to the committer to make a call whether 
> >> > consensus
> can
> >> > be assumed or a formal review period should be observed. If no 
> >> > review has taken place, such commits must have commit messages 
> >> > starting with `[Documentation]` instead of the JIRA id.
> >> >
> >> > This vote will be open for 48 hours
> >> >
> >> > [] +1 Allow [Documentation] commits without JIRA and review [] +0 
> >> > no opinion [] -1 Do not allow [Documentation] commits because ...
> >> >
> >> > Markus
> >> >
> >>
> >
> >
> >
> > --
> > Byung-Gon Chun
>
>
>
> --
> Anupam
> Bellevue, WA
> Ph: +1 (425)-777-5570
>
Mime
View raw message