reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mariia Mykhailova (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (REEF-1029) Migrate Org.Apache.REEF.Tests\Functional to xUnit
Date Mon, 01 Feb 2016 19:49:39 GMT

    [ https://issues.apache.org/jira/browse/REEF-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126897#comment-15126897
] 

Mariia Mykhailova edited comment on REEF-1029 at 2/1/16 7:49 PM:
-----------------------------------------------------------------

This group of tests uses {{Timeout}} attribute extensively, configuring 12 tests to fail if
any of them takes over 3 minutes. 
xUnit doesn't support such behavior (they used to support this in V1 but dropped in V2 saying
that in multithreaded test execution this is not useful).

It is possible to implement this attribute in our code, but this requires significant work
(similar to what nunit does). On the other hand, I've never seen timeout as a cause of test
failure, so it's probably not something we hit often. Once we configure CI tests for .NET
code, there will be an overall timeout, so we'll be able to see if tests overall start to
run longer.

Do you think we could do this migration without enforcing timeout on these tests, and file
a separate issue on implementing timeout and enforcing it on them to be done separately?


was (Author: mariiamykhailova):
This group of tests uses {{Timeout}} attribute extensively, configuring 12 tests to fail if
any of them takes over 3 minutes. 
xUnit doesn't support such behavior (they used to support this in V1 but dropped in V2 saying
that in multithreaded test execution this is not useful).

It is possible to implement this attribute in our code, but this requires significant work.
On the other hand, I've never seen timeout as a cause of test failure, so it's probably not
something we hit often. Once we configure CI tests for .NET code, there will be an overall
timeout, so we'll be able to see if tests overall start to run longer.

Do you think we could do this migration without enforcing timeout on these tests, and file
a separate issue on implementing timeout and enforcing it on them to be done separately?

> Migrate Org.Apache.REEF.Tests\Functional to xUnit
> -------------------------------------------------
>
>                 Key: REEF-1029
>                 URL: https://issues.apache.org/jira/browse/REEF-1029
>             Project: REEF
>          Issue Type: Sub-task
>          Components: REEF.NET
>            Reporter: Mariia Mykhailova
>
> Attributes used are:
>  * {{Priority(0)}} => {{Trait("Priority", "0")}}
>  * {{TestCategory("Functional")}} => {{Trait("Category", "Functional")}}
>  * {{Ignore}} => {{Fact(Skip="reason")}}
>  * {{TestInitialize}} => parameterless constructor
>  * {{TestCleanup}} => http://xunit.github.io/docs/comparisons.html suggests {{IDisposable.Dispose}}
>  * {{Description}}
>  * {{DeploymentItem}}
>  * {{Timeout}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message