reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Byung-Gon Chun <bgc...@gmail.com>
Subject Re: code review
Date Tue, 09 Feb 2016 06:57:28 GMT
Sounds good to me!
-Gon

On Tue, Feb 9, 2016 at 3:22 PM, Julia Wang (QIUHE) <Qiuhe.Wang@microsoft.com
> wrote:

> When we use CodeFlow or some other tools, we used to specify required and
> optional code reviewers. This is to make sure the modified code are
> reviewed by people who also worked on that code before, or who are also
> working on the related portions. When we send a PR for review though
> GitHub, there is no place for us to specify who are the required reviewers.
> I would suggest us to use @alias to specify required reviewers when
> seeding a PR for review. In this way, people won't miss any code review.
> For those who are not mentioned, they can always be optional reviewers.
>
> What do you think?
>
> Thanks,
> Julia
>



-- 
Byung-Gon Chun

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message