reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Chung (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (REEF-1134) Wake Codec creation pattern is not consistent
Date Thu, 21 Jan 2016 00:52:39 GMT

    [ https://issues.apache.org/jira/browse/REEF-1134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15109833#comment-15109833
] 

Andrew Chung commented on REEF-1134:
------------------------------------

I've deprecated the `ICodecFactory` interface since:
# Only `ByteCodec` uses `ICodecFactory`.
# `ByteCodec` itself has an injectable `public` constructor.
# `ICodecFactory` is not actually used anywhere in the codebase.
# `ICodecFactory` returns `object` instead of either `ICodec` or `ICodec<T>`.
# REEF Java uses injectable `public` constructors.

> Wake Codec creation pattern is not consistent
> ---------------------------------------------
>
>                 Key: REEF-1134
>                 URL: https://issues.apache.org/jira/browse/REEF-1134
>             Project: REEF
>          Issue Type: Bug
>          Components: Wake.NET
>            Reporter: Andrew Chung
>            Assignee: Andrew Chung
>
> Currently, there are a few ways to instantiate Wake Codecs, but there is no consistent
pattern. Codecs should either all be created via injection or all be created via factories,
but not both ways.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message