reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mariia Mykhailova (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (REEF-1115) Increase maximum depth of package name of Tint and fix example images
Date Wed, 13 Jan 2016 23:28:39 GMT

     [ https://issues.apache.org/jira/browse/REEF-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Mariia Mykhailova resolved REEF-1115.
-------------------------------------
       Resolution: Fixed
    Fix Version/s: 0.14

Resolved via [PR 750|https://github.com/apache/reef/pull/750]

> Increase maximum depth of package name of Tint and fix example images
> ---------------------------------------------------------------------
>
>                 Key: REEF-1115
>                 URL: https://issues.apache.org/jira/browse/REEF-1115
>             Project: REEF
>          Issue Type: Bug
>          Components: Tang
>            Reporter: Dongjoon Hyun
>            Assignee: Dongjoon Hyun
>            Priority: Minor
>             Fix For: 0.14
>
>
> This issue fixes the following three items.
> *1. Tint.java*
> Historically, `Tint` uses 4 to determine the minimum depth of package name. In order
to preserve the behavior, it should be increase into 5 because we use the package prefix 'org.apache.reef'
instead of 'com.microsoft'. This change is needed to be consistent with `lang/java/reef-tang/README.md`.
> {code:title=Tint.java|borderStyle=solid}
>            final String[] tok = fullName.split("\\.");
>            final StringBuffer sb = new StringBuffer(tok[0]);
>            for (int j = 1; j < tok.length; j++) {
> -            if (tok[j].matches("^[A-Z].*") || j > 4) {
> +            if (tok[j].matches("^[A-Z].*") || j > 5) {
> {code}
> *2. tangdoc.png*
> We need to replace `com.microsoft.tang.examples.timer` with `org.apache.reef.tang.examples.timer`.
> *3. tooltip.png*
> We need to replace `com.microsoft.tang.examples.Timer.Seconds` with `org.apache.reef.tang.examples.Timer.Seconds`.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message