reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Dudoladov (JIRA)" <>
Subject [jira] [Commented] (REEF-1108) Enable IllegalCatch checkstyle check
Date Tue, 19 Jan 2016 17:33:40 GMT


Sergey Dudoladov commented on REEF-1108:

If you want to exclude `Exception` for some reason, please update this JIRA first.

Thank you for pointing this out. I excluded {{java.lang.Exception}} because it is legitimately
caught too often.

In fact, the number of `SuppressWarnings` annotation seems to exceed the number of the changed
`catch` statement. I'm afraid that It's a little bit not proper rule for REEF coding style.
How do you think about that?

These 'SuppressWarnings' mostly happen because of the attempt to catch {{Throwable}}. Given
that there are many legitimate cases to do so, we can remove it from the check. To avoid accidental
overcatching, we can put a note in code review guidelines to double check {{catch (Throwable
... )}} statements.

I can file a separate issue to fix the current code that overcatches {{Throwable}} 

Does it seem sensible ?

> Enable IllegalCatch checkstyle check
> ------------------------------------
>                 Key: REEF-1108
>                 URL:
>             Project: REEF
>          Issue Type: Sub-task
>          Components: Build infrastructure, Documentation
>            Reporter: Sergey Dudoladov
>            Assignee: Sergey Dudoladov
> Suggested value for the {{illegalClassNames}} parameter: the default plus {{java.lang.Error}}

This message was sent by Atlassian JIRA

View raw message