reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mariia Mykhailova (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (REEF-1079) Fix TestNamedParameterWithAliasRoundTrip test failures
Date Wed, 20 Jan 2016 00:10:39 GMT

    [ https://issues.apache.org/jira/browse/REEF-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15107707#comment-15107707
] 

Mariia Mykhailova commented on REEF-1079:
-----------------------------------------

[~afchung90], do you know how to do regression testing for this? If so, we could use it for
performance check as well - I've looked at timing when running tests, but I haven't noticed
any significant change.

> Fix TestNamedParameterWithAliasRoundTrip test failures
> ------------------------------------------------------
>
>                 Key: REEF-1079
>                 URL: https://issues.apache.org/jira/browse/REEF-1079
>             Project: REEF
>          Issue Type: Bug
>            Reporter: Mariia Mykhailova
>            Assignee: Mariia Mykhailova
>
> The method {{ProtocolBufferClassHierarchy.SerializeNode}} iterates over all children
of a node, serializing them one by one.
> {noformat}
> foreach (INode child in n.GetChildren())
> {
>     children.Add(SerializeNode(child));
> }
> {noformat}
> If the list of children is changed in a different thread, this code will throw {{System.InvalidOperationException
: Collection was modified after the enumerator was instantiated.}}. We observe this in {{TestNamedParameterWithAliasRoundTrip}}
test which passes when executed individually but fails when executed in parallel with other
tests which don't do serialization, just use default {{ClassHierarchy}}.
> We need to fix the failures of this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message