reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Julia (JIRA)" <>
Subject [jira] [Commented] (REEF-1079) Fix TestNamedParameterWithAliasRoundTrip test failures
Date Tue, 19 Jan 2016 23:18:39 GMT


Julia commented on REEF-1079:

I am OK to remove the cache for default class hierarchy. If Andrew can help to do some regression
testing for ASA, that would be nice. 

> Fix TestNamedParameterWithAliasRoundTrip test failures
> ------------------------------------------------------
>                 Key: REEF-1079
>                 URL:
>             Project: REEF
>          Issue Type: Bug
>            Reporter: Mariia Mykhailova
>            Assignee: Mariia Mykhailova
> The method {{ProtocolBufferClassHierarchy.SerializeNode}} iterates over all children
of a node, serializing them one by one.
> {noformat}
> foreach (INode child in n.GetChildren())
> {
>     children.Add(SerializeNode(child));
> }
> {noformat}
> If the list of children is changed in a different thread, this code will throw {{System.InvalidOperationException
: Collection was modified after the enumerator was instantiated.}}. We observe this in {{TestNamedParameterWithAliasRoundTrip}}
test which passes when executed individually but fails when executed in parallel with other
tests which don't do serialization, just use default {{ClassHierarchy}}.
> We need to fix the failures of this test.

This message was sent by Atlassian JIRA

View raw message