reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mariia Mykhailova (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (REEF-1079) Fix TestNamedParameterWithAliasRoundTrip test failures
Date Thu, 14 Jan 2016 19:43:39 GMT

    [ https://issues.apache.org/jira/browse/REEF-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15057095#comment-15057095
] 

Mariia Mykhailova edited comment on REEF-1079 at 1/14/16 7:43 PM:
------------------------------------------------------------------

PR https://github.com/apache/reef/pull/732 - solves the problem but doesn't address the root
cause, closed without merging.


was (Author: mariiamykhailova):
PR https://github.com/apache/reef/pull/732

> Fix TestNamedParameterWithAliasRoundTrip test failures
> ------------------------------------------------------
>
>                 Key: REEF-1079
>                 URL: https://issues.apache.org/jira/browse/REEF-1079
>             Project: REEF
>          Issue Type: Bug
>            Reporter: Mariia Mykhailova
>            Assignee: Mariia Mykhailova
>
> The method {{ProtocolBufferClassHierarchy.SerializeNode}} iterates over all children
of a node, serializing them one by one.
> {noformat}
> foreach (INode child in n.GetChildren())
> {
>     children.Add(SerializeNode(child));
> }
> {noformat}
> If the list of children is changed in a different thread, this code will throw {{System.InvalidOperationException
: Collection was modified after the enumerator was instantiated.}}. We observe this in {{TestNamedParameterWithAliasRoundTrip}}
test which passes when executed individually but fails when executed in parallel with other
tests which don't do serialization, just use default {{ClassHierarchy}}.
> We need to fix the failures of this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message