reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mariia Mykhailova (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (REEF-1079) Put a lock in ProtocolBufferClassHierarchy.SerializeNode
Date Thu, 14 Jan 2016 00:41:39 GMT

     [ https://issues.apache.org/jira/browse/REEF-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Mariia Mykhailova updated REEF-1079:
------------------------------------
    Description: 
The method {{ProtocolBufferClassHierarchy.SerializeNode}} iterates over all children of a
node, serializing them one by one.

{noformat}
foreach (INode child in n.GetChildren())
{
    children.Add(SerializeNode(child));
}
{noformat}

If the list of children is changed in a different thread, this code will throw {{System.InvalidOperationException
: Collection was modified after the enumerator was instantiated.}}. We observe this in {{TestNamedParameterWithAliasRoundTrip}}
test which passes when executed individually but fails when executed in parallel with other
tests which don't do serialization, just use default {{ClassHierarchy}}.

We need to fix the failures of this test.

  was:
The method iterates over all children of a node, serializing them one by one.

{noformat}
foreach (INode child in n.GetChildren())
{
    children.Add(SerializeNode(child));
}
{noformat}

If the list of children is changed in a different thread, this code will throw {{System.InvalidOperationException
: Collection was modified after the enumerator was instantiated.}}. We observe this in {{TestNamedParameterWithAliasRoundTrip}}
test which passes when executed individually but fails when executed in parallel with other
tests. Adding a lock around this loop solves the issue.


> Put a lock in ProtocolBufferClassHierarchy.SerializeNode
> --------------------------------------------------------
>
>                 Key: REEF-1079
>                 URL: https://issues.apache.org/jira/browse/REEF-1079
>             Project: REEF
>          Issue Type: Bug
>            Reporter: Mariia Mykhailova
>            Assignee: Mariia Mykhailova
>
> The method {{ProtocolBufferClassHierarchy.SerializeNode}} iterates over all children
of a node, serializing them one by one.
> {noformat}
> foreach (INode child in n.GetChildren())
> {
>     children.Add(SerializeNode(child));
> }
> {noformat}
> If the list of children is changed in a different thread, this code will throw {{System.InvalidOperationException
: Collection was modified after the enumerator was instantiated.}}. We observe this in {{TestNamedParameterWithAliasRoundTrip}}
test which passes when executed individually but fails when executed in parallel with other
tests which don't do serialization, just use default {{ClassHierarchy}}.
> We need to fix the failures of this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message