Return-Path: X-Original-To: apmail-reef-dev-archive@minotaur.apache.org Delivered-To: apmail-reef-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 061C1181DB for ; Sat, 12 Dec 2015 00:15:47 +0000 (UTC) Received: (qmail 70999 invoked by uid 500); 12 Dec 2015 00:15:46 -0000 Delivered-To: apmail-reef-dev-archive@reef.apache.org Received: (qmail 70964 invoked by uid 500); 12 Dec 2015 00:15:46 -0000 Mailing-List: contact dev-help@reef.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@reef.apache.org Delivered-To: mailing list dev@reef.apache.org Received: (qmail 70890 invoked by uid 99); 12 Dec 2015 00:15:46 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 12 Dec 2015 00:15:46 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 97DB62C03DA for ; Sat, 12 Dec 2015 00:15:46 +0000 (UTC) Date: Sat, 12 Dec 2015 00:15:46 +0000 (UTC) From: "Mariia Mykhailova (JIRA)" To: dev@reef.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (REEF-1055) Enable StyleCop.CSharp.ReadabilityRules and fix violations MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/REEF-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mariia Mykhailova updated REEF-1055: ------------------------------------ Description: I suggest we adopt all rules, except: * SA1101: PrefixLocalCallsWithThis and SA1126: PrefixCallsCorrectly which require that we add {{this.}} whenever we reference class member. For similar issue in Java we decided against it. * SA1115: ParameterMustFollowComma which produces lots of violations which look like false positives (we don't have empty lines in lists of parametes). * SA1116: SplitParametersMustStartOnLineAfterDeclaration and SA1117: ParametersMustBeOnSameLineOrSeparateLines which increase code length for methods with multiple short parameters without increasing readability. The rest of the rules produce under 200 violations. was: I suggest we adopt all rules, except: * SA1101: PrefixLocalCallsWithThis and SA1126: PrefixCallsCorrectly which require that we add {{this.}} whenever we reference class member. For similar issue in Java we decided against it. * SA1115: ParameterMustFollowComma which produces lots of violations which look like false positives (we don't have empty lines in lists of parametes). The rest of the rules produce ~200 violations. > Enable StyleCop.CSharp.ReadabilityRules and fix violations > ---------------------------------------------------------- > > Key: REEF-1055 > URL: https://issues.apache.org/jira/browse/REEF-1055 > Project: REEF > Issue Type: Sub-task > Components: REEF.NET > Reporter: Mariia Mykhailova > Priority: Minor > > I suggest we adopt all rules, except: > * SA1101: PrefixLocalCallsWithThis and SA1126: PrefixCallsCorrectly which require that we add {{this.}} whenever we reference class member. For similar issue in Java we decided against it. > * SA1115: ParameterMustFollowComma which produces lots of violations which look like false positives (we don't have empty lines in lists of parametes). > * SA1116: SplitParametersMustStartOnLineAfterDeclaration and SA1117: ParametersMustBeOnSameLineOrSeparateLines which increase code length for methods with multiple short parameters without increasing readability. > The rest of the rules produce under 200 violations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)