Mailing-List: contact dev-help@reef.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@reef.apache.org
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\))
Subject: Re: Add dependency to Immutables?
From: Tae-Geon Um <taegeonum@gmail.com>
In-Reply-To: <5679CF9E.1080101@weimo.de>
Date: Sun, 27 Dec 2015 21:06:09 +0900
Content-Transfer-Encoding: quoted-printable
Message-Id: <BBD7C0C1-E252-4457-9EAE-A9705757C882@gmail.com>
References: <5679CF9E.1080101@weimo.de>
To: dev@reef.apache.org

Hi,=20

I=E2=80=99ve take a look at it.=20

The advantages of Immutables are that
1) it can reduce the number of code lines
	 - Simple immutable classes, just having simple getter methods, =
can be generated easily.
	 - But, if the class has complex getter methods (such as sum of =
the vector elements), the reduction of code lines would not be huge. =20

The disadvantages of Immutables are that=20
1) It doesn=E2=80=99t seem that Immutables is compatible with Tang =
@inject.=20
2) it does not support generics, such as Optional<T> class in REEF.

It seems that using Immutable has little merit to us.
Any thoughts?=20

Taegeon

> On Dec 23, 2015, at 7:33 AM, Markus Weimer <markus@weimo.de> wrote:
>=20
> Hi,
>=20
> I just came across the Immutables library[0]. This looks like a rather =
handy tool to replace many of the boring immutable data classes in REEF =
with generated code. The license is compatible with us. What do you =
think?
>=20
> Markus
>=20
> [0]: http://immutables.github.io/