reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Dudoladov (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (REEF-1066) Clarify differences between REEF job identifiers.
Date Fri, 11 Dec 2015 16:13:11 GMT

     [ https://issues.apache.org/jira/browse/REEF-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sergey Dudoladov updated REEF-1066:
-----------------------------------
    Description: 
 REEF references a single job using  the  named parameters {{LaunchID}}, {{JobIdentifier}},
{{ApplicationIdentifier}} and _possibly others_. The {{EvaluatorConfiguration.java}} (lines
60-61) binds {{LaunchID}} and {{ApplicationIdentifier}} to the same optional parameter {{APPLICATION_IDENTIFIER}},
which {{AllocatedEvaluatorImpl.java}} (line 301) resets to whatever value its {{jobIdentifier}}
_field_ contains.


This issue should
1) Add tests to ensure that the intended naming behavior is not lost by accident.
2) Modify the comments and doc strings of the parameters above to describe when to use which
parameter.
3) Add reasonable default values to the parameters.

For more details, look at the [pull request for REEF-818 |https://github.com/apache/reef/pull/700#issuecomment-163846993
]

  was:
 REEF references a single job using  the  named parameters {{LaunchID}}, {{JobIdentifier}},
{{ApplicationIdentifier}} and possibly others. The {{EvaluatorConfiguration.java}} (lines
60-61) binds {{LaunchID}} and {{ApplicationIdentifier}} to the same optional parameter {{APPLICATION_IDENTIFIER}},
which {{AllocatedEvaluatorImpl.java}} (line 301) resets to whatever value its {{jobIdentifier}}
_field_ contains.


This issue should
1) Modify the comments and doc strings of the parameters above to describe when to use which
parameter.
2) Add tests to ensure that the intended naming behavior is not lost by accident.

For more details, look at the [pull request for REEF-818 |https://github.com/apache/reef/pull/700#issuecomment-163846993
]


> Clarify differences between REEF job identifiers.
> -------------------------------------------------
>
>                 Key: REEF-1066
>                 URL: https://issues.apache.org/jira/browse/REEF-1066
>             Project: REEF
>          Issue Type: Improvement
>          Components: Build infrastructure, Documentation
>            Reporter: Sergey Dudoladov
>            Priority: Minor
>
>  REEF references a single job using  the  named parameters {{LaunchID}}, {{JobIdentifier}},
{{ApplicationIdentifier}} and _possibly others_. The {{EvaluatorConfiguration.java}} (lines
60-61) binds {{LaunchID}} and {{ApplicationIdentifier}} to the same optional parameter {{APPLICATION_IDENTIFIER}},
which {{AllocatedEvaluatorImpl.java}} (line 301) resets to whatever value its {{jobIdentifier}}
_field_ contains.
> This issue should
> 1) Add tests to ensure that the intended naming behavior is not lost by accident.
> 2) Modify the comments and doc strings of the parameters above to describe when to use
which parameter.
> 3) Add reasonable default values to the parameters.
> For more details, look at the [pull request for REEF-818 |https://github.com/apache/reef/pull/700#issuecomment-163846993
]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message