reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Dudoladov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (REEF-1066) Clarify differences between REEF job identifiers.
Date Mon, 14 Dec 2015 09:22:46 GMT

    [ https://issues.apache.org/jira/browse/REEF-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055687#comment-15055687
] 

Sergey Dudoladov commented on REEF-1066:
----------------------------------------

{quote}
An attempt number
{quote}

Does the 'attempt' mean any restart of the {{Driver}} or only resubmission of the whole job
?

{quote}
all 3 of them should be available to applications to introspect. Both on the Driver and on
the Evaluator
{quote}

We may consider exposing {{DriverInformation}} to the {{Client}} as well, e.g. to allow a
client to track the current {{DriverAttemptNumber}} if this identifier changes after restarts.

{quote}
For logging purposes, we should use a concatenation of those
{quote}

The {{DriverInformation}} should have a default {{String}} representation. Otherwise, one
can easily forget to concatenate identifiers while logging.

{quote}
What do you think?
{quote}

I am unfamiliar with REEF.NET but for the java REEF this design seems to be a good starting
point. 


> Clarify differences between REEF job identifiers.
> -------------------------------------------------
>
>                 Key: REEF-1066
>                 URL: https://issues.apache.org/jira/browse/REEF-1066
>             Project: REEF
>          Issue Type: Improvement
>          Components: Build infrastructure, Documentation, REEF-Common
>            Reporter: Sergey Dudoladov
>
>  REEF references a single job using  the  named parameters {{LaunchID}}, {{JobIdentifier}},
{{ApplicationIdentifier}} and _possibly others_. The {{EvaluatorConfiguration.java}} (lines
60-61) binds {{LaunchID}} and {{ApplicationIdentifier}} to the same optional parameter {{APPLICATION_IDENTIFIER}},
which {{AllocatedEvaluatorImpl.java}} (line 301) resets to whatever value its {{jobIdentifier}}
_field_ contains.
> This issue should
> 1) Add tests to ensure that the intended naming behavior is not lost by accident.
> 2) Modify the comments and doc strings of the parameters above to describe when to use
which parameter.
> 3) Add reasonable default values to the parameters.
> 4) Document the use of identifiers in the REEF wiki.
> For more details, look at the [initial pull request for REEF-818 |https://github.com/apache/reef/pull/700#issuecomment-163846993
]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message