reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mariia Mykhailova (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (REEF-1058) Enable StyleCop.CSharp.LayoutRules and fix violations
Date Fri, 11 Dec 2015 00:16:11 GMT

    [ https://issues.apache.org/jira/browse/REEF-1058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15051903#comment-15051903
] 

Mariia Mykhailova commented on REEF-1058:
-----------------------------------------

PR https://github.com/apache/reef/pull/722

> Enable StyleCop.CSharp.LayoutRules and fix violations
> -----------------------------------------------------
>
>                 Key: REEF-1058
>                 URL: https://issues.apache.org/jira/browse/REEF-1058
>             Project: REEF
>          Issue Type: Sub-task
>          Components: REEF.NET
>            Reporter: Mariia Mykhailova
>            Assignee: Mariia Mykhailova
>            Priority: Minor
>
> We should enforce all layout rules, except: 
> * SA1513: ClosingCurlyBracketMustBeFollowedByBlankLine which our code violates 764 times
(the rest of rules together are violated 290 times, with some pieces of code violating multiple
rules), and which doesn't really add a lot of readability.
> * SA1516: ElementsMustBeSeparatedByBlankLine which doesn't improve readability much,
since ReSharper reference count separates elements anyways.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message