reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mariia Mykhailova (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (REEF-1055) Enable StyleCop.CSharp.ReadabilityRules and fix violations
Date Fri, 11 Dec 2015 00:50:10 GMT

     [ https://issues.apache.org/jira/browse/REEF-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Mariia Mykhailova updated REEF-1055:
------------------------------------
    Description: 
I suggest we adopt all rules, except:

* SA1101: PrefixLocalCallsWithThis and SA1126: PrefixCallsCorrectly which require that we
add {{this.}} whenever we reference class member. For similar issue in Java we decided against
it.
* SA1115: ParameterMustFollowComma which produces lots of violations which look like false
positives (we don't have empty lines in lists of parametes).

The rest of the rules produce ~200 violations.

  was:
I suggest we adopt all rules, except:

* SA1101: PrefixLocalCallsWithThis and SA1126: PrefixCallsCorrectly which require that we
add {{this.}} whenever we reference class member. For similar issue in Java we decided against
it.
* SA1115: ParameterMustFollowComma which produces lots of violations which look like false
positives (we don't have empty lines in lists of parametes).


> Enable StyleCop.CSharp.ReadabilityRules and fix violations
> ----------------------------------------------------------
>
>                 Key: REEF-1055
>                 URL: https://issues.apache.org/jira/browse/REEF-1055
>             Project: REEF
>          Issue Type: Sub-task
>          Components: REEF.NET
>            Reporter: Mariia Mykhailova
>            Priority: Minor
>
> I suggest we adopt all rules, except:
> * SA1101: PrefixLocalCallsWithThis and SA1126: PrefixCallsCorrectly which require that
we add {{this.}} whenever we reference class member. For similar issue in Java we decided
against it.
> * SA1115: ParameterMustFollowComma which produces lots of violations which look like
false positives (we don't have empty lines in lists of parametes).
> The rest of the rules produce ~200 violations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message