reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Julia (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (REEF-1049) Refactor Evaluator to properly use Tang Configuration
Date Mon, 14 Dec 2015 22:52:46 GMT

    [ https://issues.apache.org/jira/browse/REEF-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15056879#comment-15056879
] 

Julia commented on REEF-1049:
-----------------------------

REEF-1049 as a sub tack of REEF-289 is mainly for using Tang injection properly for the following
classes:
Evaluator
HeartBeatManager
Contextmanager
EvaluatorRuntime
EvaluatorSettings

Evaluator reference to EvaluatorRuntime
EvaluatorRuntime has ContextManager and HeartBeatManager

EvaluatorConfigurations is consolidated into EvaluatorSettings which contains all the deserailzed
configurations data from evaluator config file, and ContextConfiguration, Optional<TaskConfiguration>
and Optional<ServiceConfiguration> and Evaluator injector. 

The evaluator config file is passed into Evaluator exe as a command line parameter, it is
deserialized in main program so that to get injector, this injector is used to inject Evaluator,
then all nested object including EvaluatorSetting are injected. 

The logic change is out of scope of this Jira. The reference relationship among EvaluatorRuntime,
Contextmanager and HeartBeatManager are also not changed in this Jira. 

> Refactor Evaluator to properly use Tang Configuration
> -----------------------------------------------------
>
>                 Key: REEF-1049
>                 URL: https://issues.apache.org/jira/browse/REEF-1049
>             Project: REEF
>          Issue Type: Improvement
>          Components: REEF.NET, REEF.NET Evaluator
>            Reporter: Julia
>            Assignee: Julia
>
> Currently .Net Evaluator doesn't properly use Tang injection and Configuration. As we
have introduced alias, we can now use proper Tang configuration for Evaluator config. 
> A proposed changes are:
> * Make the following constructor injectable:
> ** ContextManager
> ** HeartBeatManager
> ** EvaluatorRuntime
> ** EvaluatorSettings
> * Consolidate EvaluatorSettings and EvaluatorConfiguration 
> * Simplify and refactor Evaluator



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message