reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Byung-Gon Chun (JIRA)" <>
Subject [jira] [Resolved] (REEF-1023) Handle Exceptions in Vortex callback
Date Mon, 07 Dec 2015 00:01:10 GMT


Byung-Gon Chun resolved REEF-1023.
       Resolution: Fixed
    Fix Version/s: 0.14

> Handle Exceptions in Vortex callback
> ------------------------------------
>                 Key: REEF-1023
>                 URL:
>             Project: REEF
>          Issue Type: Bug
>          Components: Vortex
>            Reporter: Yunseong Lee
>            Assignee: Andrew Chung
>             Fix For: 0.14
> REEF-505 added callback feature in Vortex. Client can register {{EventHandler<TOutput>}}
which is called when Tasklets finish. This works well in the normal case.
> However, in REEF-1002 [~bgchun] pointed it out that there is no way for client to notice
Exceptions (I should have noticed before merging the PR).
> We had a discussion to fix this, and I'm copying the most relevant comments from the
> 1.([~zpqian]) FYI the API design in .NET threadpool:
> 2. ([~afchung90]) Perhaps, instead of EventHandler, we can use Observer for the callback
instead, and invoke onError onExceptions
> 3. ([~bgchun]) It's better to use a variation of Observer. Since Observer has a specific
contract (zero or more on Next calls followed by onCompleted or onError), we can define a
subclass of Observer like ExactlyOnceObserver (better name?), which calls either onNext or
onError. onCompleted should raise an UnsupportedOperationException. How does this sound?

This message was sent by Atlassian JIRA

View raw message