reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Dudoladov (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (REEF-864) Make exception handling consistent
Date Fri, 18 Dec 2015 15:34:46 GMT

    [ https://issues.apache.org/jira/browse/REEF-864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15063984#comment-15063984
] 

Sergey Dudoladov edited comment on REEF-864 at 12/18/15 3:34 PM:
-----------------------------------------------------------------

{quote}
Please start a thread on the dev list to drive this to consensus.
{quote}

[The thread | https://mail-archives.apache.org/mod_mbox/reef-dev/201512.mbox/%3C6b61ea01064444c281354803dfed05eb%40EX-MBX02.tubit.win.tu-berlin.de%3E]

{quote}
We'll need exemptions from this.
{quote}

yep, that's true. This rule just ensures that exceptions important for the client code can
actually reach this code ([more discussion|http://stackoverflow.com/a/21950]). If there are
few special cases where we do want to catch a general exception, we can simply use the {{SuppressWarning}}
annotation with appropriate comments,

{quote}
Also, the list doesn't cover something we currently strive to do: When throwing an exception,
log it first. 
{quote}

How is it different from the "log and throw" discussion above ?


was (Author: dss-2009@yandex.ru):
{quote}
We'll need exemptions from this.
{quote}

yep, that's true. This rule just ensures that exceptions important for the client code can
actually reach this code ([more discussion|http://stackoverflow.com/a/21950]). If there are
few special cases where we do want to catch a general exception, we can simply use the {{SuppressWarning}}
annotation with appropriate comments,

{quote}
Also, the list doesn't cover something we currently strive to do: When throwing an exception,
log it first. 
{quote}

How is it different from the "log and throw" discussion above ?

> Make exception handling consistent
> ----------------------------------
>
>                 Key: REEF-864
>                 URL: https://issues.apache.org/jira/browse/REEF-864
>             Project: REEF
>          Issue Type: Improvement
>          Components: Build infrastructure, Documentation
>            Reporter: Sergey Dudoladov
>            Assignee: Sergey Dudoladov
>
> The recent [OSDI paper | https://www.usenix.org/conference/osdi14/technical-sessions/presentation/yuan]
suggest that many failures in distributed systems arise from 3 trivial mistake in exception
handling:
> 1) the handler is empty
> 2) the handler silently aborts
> 3) the handler contains phrases like “TODO” and “FIXME”, i.e. is knowingly incomplete
> The authors propose [their own checker|https://github.com/diy1/aspirator] for these cases,
but we can try to enforce any of these rules via checkstyle, for example.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message