reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Dudoladov (JIRA)" <>
Subject [jira] [Commented] (REEF-864) Make exception handling consistent
Date Fri, 18 Dec 2015 14:19:46 GMT


Sergey Dudoladov commented on REEF-864:

We'll need exemptions from this.

yep, that's true. This rule just ensures that exceptions important for the user code can actually
reach this code ([more discussion|]). If there are few special
cases where we do want to catch a general exception, we can simply use the {{SuppressWarning}}

Also, the list doesn't cover something we currently strive to do: When throwing an exception,
log it first. 

How is it different from the "log and throw" discussion above ?

> Make exception handling consistent
> ----------------------------------
>                 Key: REEF-864
>                 URL:
>             Project: REEF
>          Issue Type: Improvement
>          Components: Build infrastructure, Documentation
>            Reporter: Sergey Dudoladov
>            Assignee: Sergey Dudoladov
> The recent [OSDI paper |]
suggest that many failures in distributed systems arise from 3 trivial mistake in exception
> 1) the handler is empty
> 2) the handler silently aborts
> 3) the handler contains phrases like “TODO” and “FIXME”, i.e. is knowingly incomplete
> The authors propose [their own checker|] for these cases,
but we can try to enforce any of these rules via checkstyle, for example.

This message was sent by Atlassian JIRA

View raw message