reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Markus Weimer (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (REEF-19) Extract duplicate classes in reef-examples
Date Tue, 28 Oct 2014 15:13:34 GMT

    [ https://issues.apache.org/jira/browse/REEF-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14186927#comment-14186927
] 

Markus Weimer edited comment on REEF-19 at 10/28/14 3:13 PM:
-------------------------------------------------------------

There is a pull request addressing the issue: https://github.com/apache/incubator-reef/pull/7

That PR can be merged via {{git pull https://github.com/yunseong/incubator-reef ys-extract-reef-examples-library}}


was (Author: markus.weimer):
There is a pull request addressing the issue: https://github.com/apache/incubator-reef/pull/7

> Extract duplicate classes in reef-examples
> ------------------------------------------
>
>                 Key: REEF-19
>                 URL: https://issues.apache.org/jira/browse/REEF-19
>             Project: REEF
>          Issue Type: Improvement
>          Components: REEF Examples
>            Reporter: Yunseong Lee
>            Assignee: Markus Weimer
>
> We can find some duplicate classes exist in the multiple packages with the identical
code in reef-examples.
> For example, RetainedEvaluator, HelloREEFHttp and TaskScheduler(will be added soon) have
their own ShellTask and Command classes.
> In this case, it would be much better to extract those kind of classes commonly used
across the packages and combine them into one package as a library.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message