reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Markus Weimer <mar...@weimo.de>
Subject Re: [jira] [Created] (REEF-15) Unify utils classes
Date Mon, 27 Oct 2014 15:16:05 GMT
Hi,

first of all: It seems that comments left via email don't make it back 
onto JIRA. Which is fine by me, but we should capture the outcome of 
this thread back there.

Now, on to the question at hand: What I had in my head when I wrote 
this, but failed to write down: Let's create a submodule reef-utils to 
capture these common utility classes. The submodule shall not have any 
dependencies beyond the JDK itself. That way we get code sharing without 
blowing up the dependency structure.

Markus



On 2014-10-26 21:31, Byung-Gon Chun wrote:
> I'm fine with pulling utils used for reef-common, reef-runtime-*, reef-io,
> reef-annotations, reef-checkpoint, and a few more in a place. But I object
> to moving utils in Tang and Wake. I don't think it's good to create
> dependencies between tang and new utils. For example, moving MonotonicSet
> in Tang will create this dependency.
>
> I would like to maintain the current dependency relationships.
> reef-tang -> reef-wake -> reef-common, reef-runtime-common, reef-io, ...
>                  ------------------>
>
> Thanks.
> -Gon
>
> On Mon, Oct 27, 2014 at 7:59 AM, Markus Weimer (JIRA) <jira@apache.org>
> wrote:
>
>> Markus Weimer created REEF-15:
>> ---------------------------------
>>
>>               Summary: Unify utils classes
>>                   Key: REEF-15
>>                   URL: https://issues.apache.org/jira/browse/REEF-15
>>               Project: REEF
>>            Issue Type: Improvement
>>            Components: All
>>              Reporter: Markus Weimer
>>              Priority: Minor
>>
>>
>> REEF, Tang and Wake (and the several other subprojects) all have various
>> utils packages that we should unify. For instance, there is a{{Pair}} class
>> in reef-io and reef-common and there is a {{Tuple}} in reef-io that serves
>> the same purpose.
>>
>> I propose to move all of these utilities into a common package
>> {{org.apache.reef.utils}} with subpackages named after standard Java
>> package names. For instance, the {{Pair}}, {{Tuple}} and {{MonotonicSet}}
>> classes all would be in {{org.apache.reef.utils.collections}}.
>>
>>
>>
>> --
>> This message was sent by Atlassian JIRA
>> (v6.3.4#6332)
>>
>
>


Mime
View raw message