rave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Raminder Singh" <ramin...@apache.org>
Subject Re: Review Request: Implementation of friendsWithFriend
Date Thu, 05 Jul 2012 21:03:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5769/#review8895
-----------------------------------------------------------

Ship it!


I reviewed the patch and it look good. Thanks Viknes.

- Raminder Singh


On July 5, 2012, 6:11 p.m., Viknes B wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5769/
> -----------------------------------------------------------
> 
> (Updated July 5, 2012, 6:11 p.m.)
> 
> 
> Review request for rave and Raminder Singh.
> 
> 
> Description
> -------
> 
> Displaying mutual friends between users.
> 
> 
> This addresses bug Rave-702.
>     https://issues.apache.org/jira/browse/Rave-702
> 
> 
> Diffs
> -----
> 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/repository/impl/JpaPersonRepository.java
1356969 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/repository/impl/JpaPersonRepositoryTest.java
1356969 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/test/resources/test_data.sql
1356969 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-demo-gadgets/src/main/webapp/friends.xml
1356969 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-demo-gadgets/src/main/webapp/friendsWrapper.js
PRE-CREATION 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/db/initial_data.sql
1356969 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/main/java/org/apache/rave/opensocial/service/impl/DefaultPersonService.java
1356969 
> 
> Diff: https://reviews.apache.org/r/5769/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Viknes B
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message