Mailing-List: contact dev-help@rave.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@rave.apache.org
Date: Thu, 3 May 2012 17:42:50 +0000 (UTC)
From: "jiraposter@reviews.apache.org (JIRA)" <jira@apache.org>
To: dev@rave.apache.org
Message-ID: 
 <529098993.22836.1336066971406.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1651453538.5497.1335453497556.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (RAVE-586) Break out the navbar
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/RAVE-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267623#comment-13267623 ] 

jiraposter@reviews.apache.org commented on RAVE-586:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4930/
-----------------------------------------------------------

(Updated 2012-05-03 17:40:45.041507)


Review request for rave.


Changes
-------

Made changes based on Matt's comments.


Summary
-------

Refactored the common navbar components to the header.tag file and included that in all relevant jsp files (except mobile). I also expanded the NavigationItem code to handle parameters for the navigation item text. Moved menu generation code to the ControllerUtils class. This should eventually be loaded from a DB per ticket RAVE-589


This addresses bug RAVE-586.
    https://issues.apache.org/jira/browse/RAVE-586


Diffs (updated)
-----

  /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/PageController.java 1333570 
  /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ProfileController.java 1333570 
  /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java 1333570 
  /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/admin/AdminControllerUtil.java 1333570 
  /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/util/ControllerUtils.java 1333570 
  /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/model/NavigationItem.java 1333570 
  /trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/ProfileControllerTest.java 1333570 
  /trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/model/NavigationItemTest.java 1333570 
  /trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/model/NavigationMenuTest.java 1333570 
  /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/addwidget.jsp 1333570 
  /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp 1333570 
  /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/personProfile.jsp 1333570 
  /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp 1333570 
  /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp 1333570 
  /trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/header.tag 1333570 

Diff: https://reviews.apache.org/r/4930/diff


Testing
-------

Went through all screens to verify items showed as expected and had the correct links.


Thanks,

Chris


> Break out the navbar
> --------------------
>
>                 Key: RAVE-586
>                 URL: https://issues.apache.org/jira/browse/RAVE-586
>             Project: Rave
>          Issue Type: Sub-task
>          Components: rave-portal
>            Reporter: Chris Geer
>
> Break out the navbar (bar along the top)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira