rave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (RAVE-586) Break out the navbar
Date Thu, 03 May 2012 17:40:53 GMT

    [ https://issues.apache.org/jira/browse/RAVE-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267622#comment-13267622
] 

jiraposter@reviews.apache.org commented on RAVE-586:
----------------------------------------------------



bq.  On 2012-05-03 16:31:07, mfranklin wrote:
bq.  > Thanks a lot for the patch.  I have a couple of comments, but I like where this
is headed.  One big blocker is that I am getting an error when running the following unit
test:
bq.  > 
bq.  > Tests in error: 
bq.  >   viewPerson_ShouldAddAttributeForUser(org.apache.rave.portal.web.controller.ProfileControllerTest)
bq.  >

Fixed


bq.  On 2012-05-03 16:31:07, mfranklin wrote:
bq.  > /trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/header.tag, line 40
bq.  > <https://reviews.apache.org/r/4930/diff/2/?file=105471#file105471line40>
bq.  >
bq.  >     We need to define a better way of trimming navigation items based on security.
 Maybe associate specific nav items with roles.  
bq.  >     
bq.  >     Since URL testing was the model we were using before, I am OK with applying
this so long as a ticket is created to update the NavigationItem & corresponding checks
here to use roles or other permission structures.

I agree, I'd prefer to keep that for the future because that will affect more than just this
piece.


bq.  On 2012-05-03 16:31:07, mfranklin wrote:
bq.  > /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/util/ControllerUtils.java,
line 68
bq.  > <https://reviews.apache.org/r/4930/diff/2/?file=105462#file105462line68>
bq.  >
bq.  >     Just a note, we will want to make this more dynamic in the future.  Can you
put a ticket in JIRA to expand on this concept?  I don't think it should prevent application
of this patch, but we need to make sure we track it.

I'm assuming you mean it can't be hardcoded? I agree completely and I created that ticket
at the same time when I did this patch. RAVE-589


bq.  On 2012-05-03 16:31:07, mfranklin wrote:
bq.  > /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/util/ControllerUtils.java,
line 71
bq.  > <https://reviews.apache.org/r/4930/diff/2/?file=105462#file105462line71>
bq.  >
bq.  >     Why starts with instead of equals?

This was because the view name actually turns out to be something like template.user.page.layoutXXX
so the last part is dynamic.


bq.  On 2012-05-03 16:31:07, mfranklin wrote:
bq.  > /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/util/ControllerUtils.java,
line 104
bq.  > <https://reviews.apache.org/r/4930/diff/2/?file=105462#file105462line104>
bq.  >
bq.  >     seems like there is duplication of the same logic.  consider abstracting into
a private helper.

Fixed


bq.  On 2012-05-03 16:31:07, mfranklin wrote:
bq.  > /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/util/ControllerUtils.java,
line 92
bq.  > <https://reviews.apache.org/r/4930/diff/2/?file=105462#file105462line92>
bq.  >
bq.  >     You might just want to make the default URL / instead of /index.html.

Fixed


bq.  On 2012-05-03 16:31:07, mfranklin wrote:
bq.  > /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/model/NavigationItem.java,
line 67
bq.  > <https://reviews.apache.org/r/4930/diff/2/?file=105463#file105463line67>
bq.  >
bq.  >     Please add JavaDoc for the new attribute

Fixed


- Chris


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4930/#review7504
-----------------------------------------------------------


On 2012-04-29 22:36:46, Chris Geer wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4930/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-04-29 22:36:46)
bq.  
bq.  
bq.  Review request for rave.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Refactored the common navbar components to the header.tag file and included that in all
relevant jsp files (except mobile). I also expanded the NavigationItem code to handle parameters
for the navigation item text. Moved menu generation code to the ControllerUtils class. This
should eventually be loaded from a DB per ticket RAVE-589
bq.  
bq.  
bq.  This addresses bug RAVE-586.
bq.      https://issues.apache.org/jira/browse/RAVE-586
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/PageController.java
1331506 
bq.    /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ProfileController.java
1331506 
bq.    /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java
1331506 
bq.    /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/admin/AdminControllerUtil.java
1331506 
bq.    /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/util/ControllerUtils.java
1331506 
bq.    /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/model/NavigationItem.java
1331506 
bq.    /trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/model/NavigationItemTest.java
1331506 
bq.    /trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/model/NavigationMenuTest.java
1331506 
bq.    /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/addwidget.jsp 1331506

bq.    /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp 1331506 
bq.    /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/personProfile.jsp 1331506

bq.    /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp 1331506 
bq.    /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp 1331506 
bq.    /trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/header.tag 1331506 
bq.  
bq.  Diff: https://reviews.apache.org/r/4930/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Went through all screens to verify items showed as expected and had the correct links.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Chris
bq.  
bq.


                
> Break out the navbar
> --------------------
>
>                 Key: RAVE-586
>                 URL: https://issues.apache.org/jira/browse/RAVE-586
>             Project: Rave
>          Issue Type: Sub-task
>          Components: rave-portal
>            Reporter: Chris Geer
>
> Break out the navbar (bar along the top)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message