rave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marlon Pierce <mpie...@cs.indiana.edu>
Subject Re: [discuss] Apache Rave 0.5-incubating Release Candidate
Date Tue, 01 Nov 2011 15:08:35 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

+1 also.  Seems like the way to do it.

On 11/1/11 11:07 AM, Ciancetta, Jesse E. wrote:
>>> The error is occurring because: 1)
>>> DefaultWidgetService.registerNewWidget returns a null Widget if
>>> the url already exists, and 2) the 
>>> RavePermissionEvaluator.hasPermission functions need to handle
>>> null
>> objects
>>> better.  I'll create a bug ticket for this issue.
>>> 
>> 
>> I wrote the 1) logic but now I see it back I see room for
>> improvement. The Validator can reject the new widget if its url
>> is already present. Then if for some reason
>> DefaultWidgetService#registerNewWidget is called for a URL that
>> already exists, it can throw a (DuplicateItem)Exception instead
>> of returning null. WDYT?
> 
> +1 -- sounds good to me.
> 
>> 
>> Jasha
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.17 (Darwin)
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJOsAtzAAoJEEfVXEODPFIDwZwIAIJ1Vk90hvX+5Y26U/JekSbF
r57YRjONQaeT0mYTl0RHw8Jdc79ThGO2Je4nlldQPRSKGavAoZLq8Q5GwHM/y3Ni
adnmCMls64i846ruP/YdjwW5fQ/SJYEn/2nckUvNcBxOJFxOzTfS+seAdvTkW8WK
ViiERvvTW2wjJBVYHXG/9IVRkV92tHCaZxfSEXN3oGQu7bWQiBoB7aVLutBG/5o+
JsPcVRtdh9bqnHAvq3RpF7smZntRk6t1Qz4hlxzDWLXjPltcr1YIUOzYRDgeubxi
gXmoiTV+TBy9Wo2M6QsnS6fNzMOqugpyNFuJZ8hoyB2k8QByFwS26EXOOzDLi54=
=RrFq
-----END PGP SIGNATURE-----

Mime
View raw message