rave-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ja...@apache.org
Subject svn commit: r1160558 - in /incubator/rave/trunk: rave-portal/src/main/java/org/apache/rave/portal/repository/impl/JpaWidgetRepository.java rave-shindig/src/main/java/org/apache/rave/commoncontainer/ConfigurablePropertiesModule.java
Date Tue, 23 Aug 2011 06:32:03 GMT
Author: jasha
Date: Tue Aug 23 06:32:02 2011
New Revision: 1160558

URL: http://svn.apache.org/viewvc?rev=1160558&view=rev
Log:
Sonar: Show exception message + make constant a real constant (static final)

Modified:
    incubator/rave/trunk/rave-portal/src/main/java/org/apache/rave/portal/repository/impl/JpaWidgetRepository.java
    incubator/rave/trunk/rave-shindig/src/main/java/org/apache/rave/commoncontainer/ConfigurablePropertiesModule.java

Modified: incubator/rave/trunk/rave-portal/src/main/java/org/apache/rave/portal/repository/impl/JpaWidgetRepository.java
URL: http://svn.apache.org/viewvc/incubator/rave/trunk/rave-portal/src/main/java/org/apache/rave/portal/repository/impl/JpaWidgetRepository.java?rev=1160558&r1=1160557&r2=1160558&view=diff
==============================================================================
--- incubator/rave/trunk/rave-portal/src/main/java/org/apache/rave/portal/repository/impl/JpaWidgetRepository.java
(original)
+++ incubator/rave/trunk/rave-portal/src/main/java/org/apache/rave/portal/repository/impl/JpaWidgetRepository.java
Tue Aug 23 06:32:02 2011
@@ -37,7 +37,7 @@ public class JpaWidgetRepository extends
 
     private final Logger log = LoggerFactory.getLogger(JpaWidgetRepository.class);
 
-    private int LARGE_PAGESIZE = 1000;
+    private static final int LARGE_PAGESIZE = 1000;
 
     public JpaWidgetRepository() {
         super(Widget.class);

Modified: incubator/rave/trunk/rave-shindig/src/main/java/org/apache/rave/commoncontainer/ConfigurablePropertiesModule.java
URL: http://svn.apache.org/viewvc/incubator/rave/trunk/rave-shindig/src/main/java/org/apache/rave/commoncontainer/ConfigurablePropertiesModule.java?rev=1160558&r1=1160557&r2=1160558&view=diff
==============================================================================
--- incubator/rave/trunk/rave-shindig/src/main/java/org/apache/rave/commoncontainer/ConfigurablePropertiesModule.java
(original)
+++ incubator/rave/trunk/rave-shindig/src/main/java/org/apache/rave/commoncontainer/ConfigurablePropertiesModule.java
Tue Aug 23 06:32:02 2011
@@ -19,6 +19,11 @@
 
 package org.apache.rave.commoncontainer;
 
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Map;
+import java.util.Properties;
+
 import com.google.inject.CreationException;
 import com.google.inject.spi.Message;
 import org.apache.commons.lang.StringUtils;
@@ -27,11 +32,6 @@ import org.springframework.core.io.Class
 import org.springframework.core.io.FileSystemResource;
 import org.springframework.core.io.Resource;
 
-import java.io.IOException;
-import java.util.Arrays;
-import java.util.Map;
-import java.util.Properties;
-
 /**
  * Injects everything from the a property file as a Named value.<br/>
  * Uses the {@literal shindig.properties} file unless the system property
@@ -94,7 +94,9 @@ public class ConfigurablePropertiesModul
             }
         } catch (IOException e) {
             throw new CreationException(Arrays.asList(
-                    new Message("Unable to load properties: " + overrideProperty)));
+                    new Message("Unable to load properties from location: " + overrideProperty
+                            + ". " + e.getMessage())
+            ));
         }
 
         return initProperties;



Mime
View raw message