ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Velmurugan Periasamy <vperias...@hortonworks.com>
Subject Re: Review Request 69864: RANGER-1935:Upgrade Ranger to support Apache Hadoop 3.0.0
Date Fri, 01 Feb 2019 20:03:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69864/#review212507
-----------------------------------------------------------




hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java
Line 89 (original), 45 (patched)
<https://reviews.apache.org/r/69864/#comment298309>

    Could you please address the below issues? 
    
    1] PMD violations
    ```
    [INFO] <<< maven-pmd-plugin:3.7:check (default) < :pmd @ ranger-hbase-plugin
<<<
    [INFO]
    [INFO] --- maven-pmd-plugin:3.7:check (default) @ ranger-hbase-plugin ---
    [INFO] PMD Failure: org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java:45
Rule:DuplicateImports Priority:4 Avoid duplicate imports such as 'org.apache.hadoop.hbase.security.access.AccessControlLists'.
    [INFO] PMD Failure: org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java:79
Rule:DuplicateImports Priority:4 Avoid duplicate imports such as 'com.google.protobuf.Service'.
    [INFO] PMD Failure: org.apache.ranger.authorization.hbase.RangerAuthorizationCoprocessor:867
Rule:UnnecessaryFullyQualifiedName Priority:4 Unnecessary use of fully qualified name 'org.apache.hadoop.hbase.client.SnapshotDescription'
due to existing import 'org.apache.hadoop.hbase.client.*'.
    [INFO] PMD Failure: org.apache.ranger.authorization.hbase.RangerAuthorizationCoprocessor:896
Rule:UnnecessaryFullyQualifiedName Priority:4 Unnecessary use of fully qualified name 'org.apache.hadoop.hbase.client.SnapshotDescription'
due to existing import 'org.apache.hadoop.hbase.client.*'.
    [INFO] PMD Failure: org.apache.ranger.authorization.hbase.RangerAuthorizationCoprocessor:982
Rule:UnnecessaryFullyQualifiedName Priority:4 Unnecessary use of fully qualified name 'org.apache.hadoop.hbase.client.SnapshotDescription'
due to existing import 'org.apache.hadoop.hbase.client.*'.
    [INFO] PMD Failure: org.apache.ranger.authorization.hbase.RangerAuthorizationCoprocessor:1030
Rule:UnnecessaryFullyQualifiedName Priority:4 Unnecessary use of fully qualified name 'org.apache.hadoop.hbase.client.SnapshotDescription'
due to existing import 'org.apache.hadoop.hbase.client.*'.
    [INFO] PMD Failure: org.apache.ranger.authorization.hbase.RangerAuthorizationCoprocessor:1128
Rule:UnnecessaryFullyQualifiedName Priority:4 Unnecessary use of fully qualified name 'org.apache.hadoop.hbase.wal.WALEdit'
due to existing import 'org.apache.hadoop.hbase.wal.WALEdit'.
    [INFO] PMD Failure: org/apache/ranger/authorization/hbase/HBaseRangerAuthorizationTest.java:45
Rule:UnusedImports Priority:4 Avoid unused imports such as 'org.apache.hadoop.hbase.protobuf.generated.HBaseProtos'.
    ```
    
    2] Knox plugin test case failures
    ```
    [ERROR] Tests run: 10, Failures: 0, Errors: 10, Skipped: 0, Time elapsed: 323.179 s <<<
FAILURE! - in org.apache.ranger.services.knox.KnoxRangerTest
    [ERROR] testHDFSAllowed(org.apache.ranger.services.knox.KnoxRangerTest)  Time elapsed:
31.114 s  <<< ERROR!
    org.apache.http.NoHttpResponseException: localhost:50464 failed to respond
    	at org.apache.ranger.services.knox.KnoxRangerTest.makeWebHDFSInvocation(KnoxRangerTest.java:205)
    	at org.apache.ranger.services.knox.KnoxRangerTest.testHDFSAllowed(KnoxRangerTest.java:133)
    
    [ERROR] testStormNotUiAllowed(org.apache.ranger.services.knox.KnoxRangerTest)  Time elapsed:
30.02 s  <<< ERROR!
    org.apache.http.NoHttpResponseException: localhost:50464 failed to respond
    	at org.apache.ranger.services.knox.KnoxRangerTest.makeStormUIInvocation(KnoxRangerTest.java:235)
    	at org.apache.ranger.services.knox.KnoxRangerTest.testStormNotUiAllowed(KnoxRangerTest.java:148)
    
    [ERROR] testSolrAllowed(org.apache.ranger.services.knox.KnoxRangerTest)  Time elapsed:
30.027 s  <<< ERROR!
    org.apache.http.NoHttpResponseException: localhost:50464 failed to respond
    	at org.apache.ranger.services.knox.KnoxRangerTest.makeSolrInvocation(KnoxRangerTest.java:313)
    	at org.apache.ranger.services.knox.KnoxRangerTest.testSolrAllowed(KnoxRangerTest.java:173)
    
    [ERROR] testKafkaAllowed(org.apache.ranger.services.knox.KnoxRangerTest)  Time elapsed:
30.021 s  <<< ERROR!
    org.apache.http.NoHttpResponseException: localhost:50464 failed to respond
    	at org.apache.ranger.services.knox.KnoxRangerTest.makeKafkaInvocation(KnoxRangerTest.java:285)
    	at org.apache.ranger.services.knox.KnoxRangerTest.testKafkaAllowed(KnoxRangerTest.java:163)
    
    [ERROR] testKafkaNotAllowed(org.apache.ranger.services.knox.KnoxRangerTest)  Time elapsed:
30.014 s  <<< ERROR!
    org.apache.http.NoHttpResponseException: localhost:50464 failed to respond
    	at org.apache.ranger.services.knox.KnoxRangerTest.makeKafkaInvocation(KnoxRangerTest.java:285)
    	at org.apache.ranger.services.knox.KnoxRangerTest.testKafkaNotAllowed(KnoxRangerTest.java:168)
    
    [ERROR] testStormUiAllowed(org.apache.ranger.services.knox.KnoxRangerTest)  Time elapsed:
30.044 s  <<< ERROR!
    org.apache.http.NoHttpResponseException: localhost:50464 failed to respond
    	at org.apache.ranger.services.knox.KnoxRangerTest.makeStormUIInvocation(KnoxRangerTest.java:235)
    	at org.apache.ranger.services.knox.KnoxRangerTest.testStormUiAllowed(KnoxRangerTest.java:143)
    
    [ERROR] testHBaseAllowed(org.apache.ranger.services.knox.KnoxRangerTest)  Time elapsed:
30.017 s  <<< ERROR!
    org.apache.http.NoHttpResponseException: localhost:50464 failed to respond
    	at org.apache.ranger.services.knox.KnoxRangerTest.makeHBaseInvocation(KnoxRangerTest.java:265)
    	at org.apache.ranger.services.knox.KnoxRangerTest.testHBaseAllowed(KnoxRangerTest.java:153)
    
    [ERROR] testSolrNotAllowed(org.apache.ranger.services.knox.KnoxRangerTest)  Time elapsed:
30.022 s  <<< ERROR!
    org.apache.http.NoHttpResponseException: localhost:50464 failed to respond
    	at org.apache.ranger.services.knox.KnoxRangerTest.makeSolrInvocation(KnoxRangerTest.java:313)
    	at org.apache.ranger.services.knox.KnoxRangerTest.testSolrNotAllowed(KnoxRangerTest.java:178)
    
    [ERROR] testHDFSNotAllowed(org.apache.ranger.services.knox.KnoxRangerTest)  Time elapsed:
30.016 s  <<< ERROR!
    org.apache.http.NoHttpResponseException: localhost:50464 failed to respond
    	at org.apache.ranger.services.knox.KnoxRangerTest.makeWebHDFSInvocation(KnoxRangerTest.java:205)
    	at org.apache.ranger.services.knox.KnoxRangerTest.testHDFSNotAllowed(KnoxRangerTest.java:138)
    
    [ERROR] testHBaseNotAllowed(org.apache.ranger.services.knox.KnoxRangerTest)  Time elapsed:
30.019 s  <<< ERROR!
    org.apache.http.NoHttpResponseException: localhost:50464 failed to respond
    	at org.apache.ranger.services.knox.KnoxRangerTest.makeHBaseInvocation(KnoxRangerTest.java:265)
    	at org.apache.ranger.services.knox.KnoxRangerTest.testHBaseNotAllowed(KnoxRangerTest.java:158)
    
    [INFO]
    [INFO] Results:
    [INFO]
    [ERROR] Errors:
    [ERROR]   KnoxRangerTest.testHBaseAllowed:153->makeHBaseInvocation:265 » NoHttpResponse
...
    [ERROR]   KnoxRangerTest.testHBaseNotAllowed:158->makeHBaseInvocation:265 » NoHttpResponse
    [ERROR]   KnoxRangerTest.testHDFSAllowed:133->makeWebHDFSInvocation:205 » NoHttpResponse
    [ERROR]   KnoxRangerTest.testHDFSNotAllowed:138->makeWebHDFSInvocation:205 » NoHttpResponse
    [ERROR]   KnoxRangerTest.testKafkaAllowed:163->makeKafkaInvocation:285 » NoHttpResponse
...
    [ERROR]   KnoxRangerTest.testKafkaNotAllowed:168->makeKafkaInvocation:285 » NoHttpResponse
    [ERROR]   KnoxRangerTest.testSolrAllowed:173->makeSolrInvocation:313 » NoHttpResponse
lo...
    [ERROR]   KnoxRangerTest.testSolrNotAllowed:178->makeSolrInvocation:313 » NoHttpResponse
    [ERROR]   KnoxRangerTest.testStormNotUiAllowed:148->makeStormUIInvocation:235 » NoHttpResponse
    [ERROR]   KnoxRangerTest.testStormUiAllowed:143->makeStormUIInvocation:235 » NoHttpResponse
    [INFO]
    [ERROR] Tests run: 10, Failures: 0, Errors: 10, Skipped: 0
    ```


- Velmurugan Periasamy


On Jan. 30, 2019, 10:43 p.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69864/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2019, 10:43 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Abhay
Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu,
and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1935
>     https://issues.apache.org/jira/browse/RANGER-1935
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-1935:Upgrade Ranger to support Apache Hadoop 3.0.0
> 
> 
> Diffs
> -----
> 
>   agents-audit/src/main/java/org/apache/ranger/audit/utils/InMemoryJAASConfiguration.java
0f29138 
>   credentialbuilder/pom.xml 461dcd0 
>   hbase-agent/pom.xml c044ef0 
>   hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/AuthorizationSession.java
9a83bc7 
>   hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/HbaseAuthUtilsImpl.java
01e0af2 
>   hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/HbaseUserUtilsImpl.java
23cd5fc 
>   hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java
ddb6d9b 
>   hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessorBase.java
1062c9e 
>   hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationFilter.java
4006afc 
>   hbase-agent/src/main/java/org/apache/ranger/services/hbase/client/HBaseClient.java
e74c3e5 
>   hbase-agent/src/test/java/org/apache/ranger/authorization/hbase/HBaseRangerAuthorizationTest.java
f1cd893 
>   hdfs-agent/src/test/java/org/apache/ranger/services/hdfs/HDFSRangerTest.java a7215ce

>   hive-agent/pom.xml 0a091b2 
>   hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizerBase.java
c313870 
>   hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java bf1bc1d

>   hive-agent/src/test/java/org/apache/ranger/services/hive/HIVERangerAuthorizerTest.java
7dc5c54 
>   kms/pom.xml 043c67f 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/EagerKeyGeneratorKeyProviderCryptoExtension.java
f853a84 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMS.java be3700f 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSAuthenticationFilter.java
ada9a56 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSWebApp.java b2540cb 
>   knox-agent/pom.xml 0c45c84 
>   plugin-yarn/src/main/java/org/apache/ranger/authorization/yarn/authorizer/RangerYarnAuthorizer.java
a4de016 
>   pom.xml 2a2540a 
>   ranger-examples/plugin-sampleapp/pom.xml bef0f5c 
>   ranger-hbase-plugin-shim/src/main/java/com/xasecure/authorization/hbase/XaSecureAuthorizationCoprocessor.java
1afe0ba 
>   ranger-hbase-plugin-shim/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java
87c6586 
>   ranger-storm-plugin-shim/pom.xml 89efe34 
>   ranger-yarn-plugin-shim/src/main/java/org/apache/ranger/authorization/yarn/authorizer/RangerYarnAuthorizer.java
7b7f1f3 
>   security-admin/pom.xml 479f46d 
>   src/main/assembly/admin-web.xml 8ea728b 
>   src/main/assembly/hbase-agent.xml 3ebc334 
>   src/main/assembly/hdfs-agent.xml 561d137 
>   src/main/assembly/hive-agent.xml 03bd31a 
>   src/main/assembly/kms.xml 3adc55c 
>   src/main/assembly/knox-agent.xml 8357d49 
>   src/main/assembly/plugin-atlas.xml 35096d0 
>   src/main/assembly/plugin-kafka.xml 7c55128 
>   src/main/assembly/plugin-kms.xml 53cf302 
>   src/main/assembly/plugin-kylin.xml f4e0820 
>   src/main/assembly/plugin-solr.xml f5fb0a7 
>   src/main/assembly/plugin-sqoop.xml d2bd69a 
>   src/main/assembly/plugin-yarn.xml c6a48e8 
>   src/main/assembly/ranger-tools.xml 249de9a 
>   src/main/assembly/storm-agent.xml fdaf678 
>   src/main/assembly/tagsync.xml 0b6596f 
>   src/main/assembly/usersync.xml d170d8c 
>   storm-agent/pom.xml a084e68 
>   tagsync/pom.xml e98cf63 
>   ugsync/ldapconfigchecktool/ldapconfigcheck/pom.xml d49001a 
>   ugsync/ldapconfigchecktool/ldapconfigcheck/src/main/java/org/apache/ranger/ldapconfigcheck/LdapConfig.java
9a77ced 
>   ugsync/pom.xml c30d8ca 
>   unixauthclient/pom.xml 4625925 
>   unixauthservice/pom.xml 4c50d6c 
> 
> 
> Diff: https://reviews.apache.org/r/69864/diff/2/
> 
> 
> Testing
> -------
> 
> Verified in Local VM
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message