ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Csaba Koncz (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (RANGER-2255) Add JavaScript unit tests
Date Tue, 08 Jan 2019 11:38:00 GMT

    [ https://issues.apache.org/jira/browse/RANGER-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16737025#comment-16737025
] 

Csaba Koncz commented on RANGER-2255:
-------------------------------------

[~pradeep.agrawal], I noticed that two Phantomjs versions are currently downloaded by npm,
one of which is deprecated. 

Removed the deprecated one (RANGER-2319), but this probably will not fix your issue, as on
Linux it is still a BZIP archive that is downloaded.

I tested the installation with Docker image node:8.15.0-alpine, there it works:

 
{code:java}
# npm i

> phantomjs-prebuilt@2.1.16 install /root/csaba/node_modules/phantomjs-prebuilt
> node install.js

PhantomJS not found on PATH
Downloading https://github.com/Medium/phantomjs/releases/download/v2.1.1/phantomjs-2.1.1-linux-x86_64.tar.bz2
Saving to /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2
Receiving...
  [========================================] 100%
Received 22866K total.
Extracting tar contents (via spawned process)
Removing /root/csaba/node_modules/phantomjs-prebuilt/lib/phantom
Copying extracted folder /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2-extract-1546944498271/phantomjs-2.1.1-linux-x86_64
-> /root/csaba/node_modules/phantomjs-prebuilt/lib/phantom
Writing location.js file
Done. Phantomjs binary available at /root/csaba/node_modules/phantomjs-prebuilt/lib/phantom/bin/phantomjs
npm WARN security-admin@2.0.0 No description
npm WARN security-admin@2.0.0 No repository field.
npm WARN security-admin@2.0.0 No license field.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.4 (node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.4: wanted
{"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

added 349 packages from 1057 contributors and audited 2496 packages in 48.538s
found 0 vulnerabilities{code}

> Add JavaScript unit tests
> -------------------------
>
>                 Key: RANGER-2255
>                 URL: https://issues.apache.org/jira/browse/RANGER-2255
>             Project: Ranger
>          Issue Type: Wish
>          Components: admin
>    Affects Versions: 0.7.0, 2.0.0, 1.2.1
>            Reporter: Csaba Koncz
>            Assignee: Csaba Koncz
>            Priority: Minor
>             Fix For: 2.0.0
>
>
> It would be nice if the admin-ui project would have JavaScript unit tests.
> As with RANGER-2220 JavaScript minification was introduced, that can lead to new type
of loading errors that were not seen before.
> It would be nice if there was an automatic check that validates the minified output.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message