ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pradeep Agrawal <pradeepagrawal8...@gmail.com>
Subject Re: Review Request 69677: RANGER-2287: Improve and optimize db_setup.py file code
Date Tue, 22 Jan 2019 13:47:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69677/
-----------------------------------------------------------

(Updated Jan. 22, 2019, 1:47 p.m.)


Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nikhil P, Ramesh
Mani, and Velmurugan Periasamy.


Changes
-------

Updated patch after one more round of testing


Bugs: RANGER-2287
    https://issues.apache.org/jira/browse/RANGER-2287


Repository: ranger


Description
-------

**Problem Statement:** There are lot of repeated code in db_setup.py which can be removed
which shall help developers to make any changes in db_setup.py in future.

**Proposed Solution:** Proposed patch shall remove the db setup methods of each db flavor
and shall use a single method for a specific work for each db flavor. Based on the db flavor,
config values shall be populated and handled in the code after this patch.


Diffs (updated)
-----

  security-admin/scripts/db_setup.py f1223b38c 


Diff: https://reviews.apache.org/r/69677/diff/3/

Changes: https://reviews.apache.org/r/69677/diff/2-3/


Testing
-------

**Use Cases covered for all the db flavors:**
*1. Fresh installation(Ranger 2.0):* Tested patch with fresh installation of ranger admin.
*2. Upgrade(from 0.7 to 2.0):* Installed Ranger from 0.7 branch and used same db config on
Ranger 2.0 installation config and run the setup.sh. Ranger was upgraded successfully.


Thanks,

Pradeep Agrawal


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message