ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zsombor Gegesy <zsom...@apache.org>
Subject Re: Review Request 69731: RANGER-2321 Docker build fails due to PhantomJS dependency
Date Sun, 13 Jan 2019 20:40:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69731/#review211940
-----------------------------------------------------------


Ship it!




Ship It!

- Zsombor Gegesy


On Jan. 13, 2019, 7:18 p.m., Csaba Koncz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69731/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2019, 7:18 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2321
>     https://issues.apache.org/jira/browse/RANGER-2321
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> - Docker image building installs the packages needed by installing and running PhantomJS
> - modified Maven build so that PhantomJS downloading and execution can be skipped by
adding -DskipJSTests to the command line
> 
> 
> Diffs
> -----
> 
>   README.txt 8aa177927 
>   build_ranger_using_docker.sh fa77d910f 
>   security-admin/pom.xml 14cafb4b2 
>   security-admin/src/main/webapp/package-lock.json 9deaf0071 
>   security-admin/src/main/webapp/package.json 880f6b34f 
>   security-admin/src/test/javascript/karma-common.conf.js 4dc9bb60f 
>   security-admin/src/test/javascript/package-lock.json PRE-CREATION 
>   security-admin/src/test/javascript/package.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/69731/diff/2/
> 
> 
> Testing
> -------
> 
> The following succeeds and runs JavaScript tests:
> 
> ```
> ./build_ranger_using_docker.sh -build_image mvn clean verify -am -pl security-admin
> ```
> 
> The following succeeds and does not run JavaScript tests and does not download PhantomJS:
> ```
> mvn clean verify -am -pl security-admin -DskipJSTests
> ```
> 
> 
> Thanks,
> 
> Csaba Koncz
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message