ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pengjianhua <peng.jian...@zte.com.cn>
Subject Re: Review Request 69297: RANGER-2280:The emptyText of User Sync and Plugin Status should be reasonable
Date Fri, 09 Nov 2018 09:17:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69297/#review210433
-----------------------------------------------------------


Ship it!




Ship It!

- pengjianhua


On 十一月 8, 2018, 7:08 a.m., Qiang Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69297/
> -----------------------------------------------------------
> 
> (Updated 十一月 8, 2018, 7:08 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam
Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, Selvamohan Neethiraj, sam  rome, Venkat
Ranganathan, Velmurugan Periasamy, and Zsombor Gegesy.
> 
> 
> Bugs: RANGER-2280
>     https://issues.apache.org/jira/browse/RANGER-2280
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> In the User Sync webpage under the Audit of Ranger Admin?
> if the form is empty, it will show emptyText:
> No plugin found!
> Refer screenshots:
> [AuditUserSyncNotFound|https://issues.apache.org/jira/secure/attachment/12947353/AuditUserSyncNotFound.jpg]
> The message shown above is not reasonable. It should be changed to:
> No user sync audit found!
> Fixed screenshots:
> [AuditUserSyncNotFound_Fix|https://issues.apache.org/jira/secure/attachment/12947354/AuditUserSyncNotFound_Fix.jpg]
> 
> Similar to User Sync, the emptyText of Plugin Status is not reasonable.
> It should be changed to:
> No plugin status found!
> Fixed screenshots:
> [AuditPluginStatusNotFound_Fix|https://issues.apache.org/jira/secure/attachment/12947352/AuditPluginStatusNotFound_Fix.jpg]
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js fe9566c 
> 
> 
> Diff: https://reviews.apache.org/r/69297/diff/1/
> 
> 
> Testing
> -------
> 
> Tested
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message