From dev-return-19597-archive-asf-public=cust-asf.ponee.io@ranger.apache.org Fri Oct 12 07:44:50 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9C34A180660 for ; Fri, 12 Oct 2018 07:44:49 +0200 (CEST) Received: (qmail 47517 invoked by uid 500); 12 Oct 2018 05:44:48 -0000 Mailing-List: contact dev-help@ranger.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ranger.apache.org Delivered-To: mailing list dev@ranger.apache.org Received: (qmail 47506 invoked by uid 99); 12 Oct 2018 05:44:47 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Oct 2018 05:44:47 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 6FE5F1A265F; Fri, 12 Oct 2018 05:44:47 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.901 X-Spam-Level: X-Spam-Status: No, score=0.901 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_MANYTO=0.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id RSt4CkadtsQm; Fri, 12 Oct 2018 05:44:43 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 7C86A5F32F; Fri, 12 Oct 2018 05:44:43 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0D5C8E02BE; Fri, 12 Oct 2018 05:44:43 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id D3E4CC41E31; Fri, 12 Oct 2018 05:44:42 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7319479565058896279==" MIME-Version: 1.0 Subject: Re: Review Request 68974: RANGER-2245: Exclude Jetty libraries From: Mehul Parikh To: Mehul Parikh , Gautam Borad , Abhay Kulkarni , Velmurugan Periasamy , deepak sharma , Ankita Sinha , Madhan Neethiraj , suja s Cc: Pradeep Agrawal , Mehul Parikh , ranger Date: Fri, 12 Oct 2018 05:44:42 -0000 Message-ID: <20181012054442.28200.38712@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mehul Parikh X-ReviewGroup: ranger X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/68974/ X-Sender: Mehul Parikh X-ReviewBoard-ShipIt: 1 References: <20181010141252.6519.12462@reviews-vm2.apache.org> In-Reply-To: <20181010141252.6519.12462@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Mehul Parikh X-ReviewRequest-Repository: ranger --===============7319479565058896279== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68974/#review209476 ----------------------------------------------------------- Ship it! Ship It! - Mehul Parikh On Oct. 10, 2018, 2:12 p.m., Pradeep Agrawal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68974/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2018, 2:12 p.m.) > > > Review request for ranger, Ankita Sinha, deepak sharma, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, suja s, and Velmurugan Periasamy. > > > Bugs: RANGER-2245 > https://issues.apache.org/jira/browse/RANGER-2245 > > > Repository: ranger > > > Description > ------- > > **Problem Statement:** Ranger does not use Jetty, it uses tomcat, so jetty libraries might be coming in as transient dependencies. In that case, we can exclude these libraries from the ranger admin packaging. > > **Proposed solution:** Exclude jetty jars from security-admin/pom.xml > > > Diffs > ----- > > security-admin/pom.xml 84bbd6650 > > > Diff: https://reviews.apache.org/r/68974/diff/1/ > > > Testing > ------- > > Steps performed for Ranger-admin(with patch): > 1. Created Build with patch and untar the build. > 2. Opened install.properties and provided db configuration in install.properties > 3. Called setup.sh > > > **Expected Behavior:** > Ranger-admin installation should finish successfully and jetty jars should not be available at location: > ranger-2.0.0-SNAPSHOT-admin/ews/webapp/WEB-INF/lib > > > **Actual Behavior:** > Ranger-admin Installation finished successfully and jetty jars was not available at location: > ranger-2.0.0-SNAPSHOT-admin/ews/webapp/WEB-INF/lib > > Note: After setup, started Ranger > > > Thanks, > > Pradeep Agrawal > > --===============7319479565058896279==--