From dev-return-19573-archive-asf-public=cust-asf.ponee.io@ranger.apache.org Thu Oct 11 06:24:56 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 787E2180672 for ; Thu, 11 Oct 2018 06:24:55 +0200 (CEST) Received: (qmail 96366 invoked by uid 500); 11 Oct 2018 04:24:54 -0000 Mailing-List: contact dev-help@ranger.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ranger.apache.org Delivered-To: mailing list dev@ranger.apache.org Received: (qmail 96355 invoked by uid 99); 11 Oct 2018 04:24:53 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Oct 2018 04:24:53 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 9D3431A0934; Thu, 11 Oct 2018 04:24:52 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.352 X-Spam-Level: ** X-Spam-Status: No, score=2.352 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_REPLYTO_END_DIGIT=0.25, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_MANYTO=0.2, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id W_-lrzC6U6CY; Thu, 11 Oct 2018 04:24:49 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id C32415F32F; Thu, 11 Oct 2018 04:24:48 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4E16AE0179; Thu, 11 Oct 2018 04:24:48 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 3C70EC4015B; Thu, 11 Oct 2018 04:24:48 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7361434221810702985==" MIME-Version: 1.0 Subject: Re: Review Request 68974: RANGER-2245: Exclude Jetty libraries From: Pradeep Agrawal To: Mehul Parikh , Gautam Borad , Abhay Kulkarni , Velmurugan Periasamy , deepak sharma , Ankita Sinha , Madhan Neethiraj , suja s Cc: Pradeep Agrawal , ranger Date: Thu, 11 Oct 2018 04:24:48 -0000 Message-ID: <20181011042448.6519.34889@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Pradeep Agrawal X-ReviewGroup: ranger X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/68974/ X-Sender: Pradeep Agrawal References: <20181010152653.6518.76114@reviews-vm2.apache.org> In-Reply-To: <20181010152653.6518.76114@reviews-vm2.apache.org> Reply-To: Pradeep Agrawal X-ReviewRequest-Repository: ranger --===============7361434221810702985== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Oct. 10, 2018, 3:26 p.m., Velmurugan Periasamy wrote: > > security-admin/pom.xml > > Lines 545 (patched) > > > > > > Could you please make sure this is merged in 1.x branches as well? Thanks. Yes, will commit in ranger-1, ranger-1.1 and ranger-1.2 branch. - Pradeep ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68974/#review209409 ----------------------------------------------------------- On Oct. 10, 2018, 2:12 p.m., Pradeep Agrawal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68974/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2018, 2:12 p.m.) > > > Review request for ranger, Ankita Sinha, deepak sharma, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, suja s, and Velmurugan Periasamy. > > > Bugs: RANGER-2245 > https://issues.apache.org/jira/browse/RANGER-2245 > > > Repository: ranger > > > Description > ------- > > **Problem Statement:** Ranger does not use Jetty, it uses tomcat, so jetty libraries might be coming in as transient dependencies. In that case, we can exclude these libraries from the ranger admin packaging. > > **Proposed solution:** Exclude jetty jars from security-admin/pom.xml > > > Diffs > ----- > > security-admin/pom.xml 84bbd6650 > > > Diff: https://reviews.apache.org/r/68974/diff/1/ > > > Testing > ------- > > Steps performed for Ranger-admin(with patch): > 1. Created Build with patch and untar the build. > 2. Opened install.properties and provided db configuration in install.properties > 3. Called setup.sh > > > **Expected Behavior:** > Ranger-admin installation should finish successfully and jetty jars should not be available at location: > ranger-2.0.0-SNAPSHOT-admin/ews/webapp/WEB-INF/lib > > > **Actual Behavior:** > Ranger-admin Installation finished successfully and jetty jars was not available at location: > ranger-2.0.0-SNAPSHOT-admin/ews/webapp/WEB-INF/lib > > Note: After setup, started Ranger > > > Thanks, > > Pradeep Agrawal > > --===============7361434221810702985==--