ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qiang Zhang <zhangqia...@zte.com.cn>
Subject Re: Review Request 69156: RANGER-2267 Add a "disabled" lable to differentiate the status of the service
Date Wed, 31 Oct 2018 06:29:56 GMT


> On 十月 30, 2018, 1:06 p.m., Nitin Galave wrote:
> > security-admin/src/main/webapp/templates/helpers/XAHelpers.js
> > Lines 529 (patched)
> > <https://reviews.apache.org/r/69156/diff/1/?file=2102416#file2102416line531>
> >
> >     It's better if we use icon for showing disable status instead of label.

Ok,I have updated the patch please review again.Thanks.


- Qiang


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69156/#review210170
-----------------------------------------------------------


On 十月 31, 2018, 6:27 a.m., Qiang Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69156/
> -----------------------------------------------------------
> 
> (Updated 十月 31, 2018, 6:27 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam
Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nitin Galave, pengjianhua, Pradeep
Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, sam  rome, Venkat Ranganathan,
and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2267
>     https://issues.apache.org/jira/browse/RANGER-2267
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> On the Service Manager page, the enabled service and the disabled service are displayed
the same, and the user cannot distinguish between them.
> Add a "disabled" lable to differentiate the status of the service
> 
> Modified screenshots:
> 
> https://issues.apache.org/jira/secure/attachment/12945573/Modify.PNG
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/webapp/templates/helpers/XAHelpers.js 27de701ae 
> 
> 
> Diff: https://reviews.apache.org/r/69156/diff/2/
> 
> 
> Testing
> -------
> 
> Test Result:
> 
> Tested.
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message