ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhay Kulkarni <akulka...@hortonworks.com>
Subject Review Request 69209: RANGER-2272: Ensure that Ranger policy contains lowercase access-type and resource-definition names
Date Mon, 29 Oct 2018 23:43:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69209/
-----------------------------------------------------------

Review request for ranger, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, and Velmurugan Periasamy.


Bugs: RANGER-2272
    https://issues.apache.org/jira/browse/RANGER-2272


Repository: ranger


Description
-------

Access type names and resources definition names in Ranger service definition are required
to be in lowercase. Ranger Policy also ensure that access type names and resource-definition
names are in lowercase when it is persisted in the database.


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java
9de860d42 
  agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidator.java
c7062ddda 
  agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerPolicyValidator.java
140a9edf5 
  agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerValidator.java
5bdffda92 


Diff: https://reviews.apache.org/r/69209/diff/1/


Testing
-------

Tested with mysql and postgres database back-ends. Created policy containing uppercase access-type
name (such as 'Read' for hive policy), and uppercase resource-def name (such as 'DATABASE'
for hive-policy). Ensured that the created policy can be retrieved using GUI. Verified that
database contained correct, lowercase access-type name ('read') and resource-def name ('database')


Thanks,

Abhay Kulkarni


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message