ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pengjianhua <peng.jian...@zte.com.cn>
Subject Re: Review Request 69080: RANGER-2257:Add policyID to error message when click the Access log of Audit
Date Tue, 23 Oct 2018 06:37:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69080/#review209911
-----------------------------------------------------------


Ship it!




Ship It!

- pengjianhua


On 十月 19, 2018, 3:26 a.m., Qiang Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69080/
> -----------------------------------------------------------
> 
> (Updated 十月 19, 2018, 3:26 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam
Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, Selvamohan Neethiraj, sam  rome, Venkat
Ranganathan, Velmurugan Periasamy, and Zsombor Gegesy.
> 
> 
> Bugs: RANGER-2257
>     https://issues.apache.org/jira/browse/RANGER-2257
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Check the Access log of Audit in RangerAdmin,
> click on a log to see its corresponding policyID history,
> If the policyID does not exist, the following error will occur:
> No policy history found for given time: 2018-08-14T08:43:11Z
> Please check the following screenshots:
> https://issues.apache.org/jira/secure/attachment/12944645/OnlyTime.png
> The information given in the above error message does not give policyID information,

> which can lead to user confusion.
> Add policyID to modify the error message as follows:
> No policy history found for given policy ID: 1 and event time: 2018-08-14T08:43:11Z
> Modified screenshots:
> https://issues.apache.org/jira/secure/attachment/12944644/IDandTime.png
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 5dfe446 
> 
> 
> Diff: https://reviews.apache.org/r/69080/diff/1/
> 
> 
> Testing
> -------
> 
> #Test Result:
> Tested.
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message