ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pradeep Agrawal <pradeepagrawal8...@gmail.com>
Subject Re: Review Request 68974: RANGER-2245: Exclude Jetty libraries
Date Thu, 11 Oct 2018 04:24:48 GMT


> On Oct. 10, 2018, 3:26 p.m., Velmurugan Periasamy wrote:
> > security-admin/pom.xml
> > Lines 545 (patched)
> > <https://reviews.apache.org/r/68974/diff/1/?file=2095947#file2095947line545>
> >
> >     Could you please make sure this is merged in 1.x branches as well? Thanks.

Yes, will commit in ranger-1, ranger-1.1 and ranger-1.2 branch.


- Pradeep


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68974/#review209409
-----------------------------------------------------------


On Oct. 10, 2018, 2:12 p.m., Pradeep Agrawal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68974/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2018, 2:12 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, deepak sharma, Gautam Borad, Abhay Kulkarni,
Madhan Neethiraj, Mehul Parikh, suja s, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2245
>     https://issues.apache.org/jira/browse/RANGER-2245
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> **Problem Statement:** Ranger does not use Jetty, it uses tomcat, so jetty libraries
might be coming in as transient dependencies. In that case, we can exclude these libraries
from the ranger admin packaging.
> 
> **Proposed solution:** Exclude jetty jars from security-admin/pom.xml
> 
> 
> Diffs
> -----
> 
>   security-admin/pom.xml 84bbd6650 
> 
> 
> Diff: https://reviews.apache.org/r/68974/diff/1/
> 
> 
> Testing
> -------
> 
> Steps performed for Ranger-admin(with patch):
> 1. Created Build with patch and untar the build.
> 2. Opened install.properties and provided db configuration in install.properties
> 3. Called setup.sh
> 
> 
> **Expected Behavior:**
> Ranger-admin installation should finish successfully and jetty jars should not be available
at location: 
> ranger-2.0.0-SNAPSHOT-admin/ews/webapp/WEB-INF/lib
> 
> 
> **Actual Behavior:**
> Ranger-admin Installation finished successfully and jetty jars was not available at location:

> ranger-2.0.0-SNAPSHOT-admin/ews/webapp/WEB-INF/lib
> 
> Note: After setup, started Ranger
> 
> 
> Thanks,
> 
> Pradeep Agrawal
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message