ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qiang Zhang <zhangqia...@zte.com.cn>
Subject Re: Review Request 68871: RANGER-2238 String comparison should not use ‘==’ in ServiceUtil.java
Date Mon, 08 Oct 2018 02:08:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68871/
-----------------------------------------------------------

(Updated 十月 8, 2018, 2:08 a.m.)


Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad,
Madhan Neethiraj, Mehul Parikh, Nitin Galave, pengjianhua, Pradeep Agrawal, Ramesh Mani, Selvamohan
Neethiraj, sam  rome, Venkat Ranganathan, and Velmurugan Periasamy.


Bugs: RANGER-2238
    https://issues.apache.org/jira/browse/RANGER-2238


Repository: ranger


Description
-------

Here is related code:

for(RangerPolicy.RangerPolicyItemCondition condition : policyItem.getConditions()) {
    if(condition.getType() == "ipaddress") {

equals() should be used to compare Strings.


Diffs (updated)
-----

  security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java 0292881b4 


Diff: https://reviews.apache.org/r/68871/diff/2/

Changes: https://reviews.apache.org/r/68871/diff/1-2/


Testing
-------


Thanks,

Qiang Zhang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message