From dev-return-19318-archive-asf-public=cust-asf.ponee.io@ranger.apache.org Wed Sep 26 11:01:34 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 139BF180629 for ; Wed, 26 Sep 2018 11:01:33 +0200 (CEST) Received: (qmail 29593 invoked by uid 500); 26 Sep 2018 09:01:33 -0000 Mailing-List: contact dev-help@ranger.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ranger.apache.org Delivered-To: mailing list dev@ranger.apache.org Received: (qmail 29582 invoked by uid 99); 26 Sep 2018 09:01:32 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Sep 2018 09:01:32 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 2A61EC0158; Wed, 26 Sep 2018 09:01:32 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.901 X-Spam-Level: X-Spam-Status: No, score=0.901 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_MANYTO=0.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id sWu3be40KeHE; Wed, 26 Sep 2018 09:01:31 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 8F3D65F197; Wed, 26 Sep 2018 09:01:30 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E2366E006D; Wed, 26 Sep 2018 09:01:29 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id B500DC40046; Wed, 26 Sep 2018 09:01:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1255458758811470259==" MIME-Version: 1.0 Subject: Review Request 68849: RANGER-2235 Modify the login session detail page as a modal. From: Qiang Zhang To: Venkat Ranganathan , Mehul Parikh , Gautam Borad , Ramesh Mani , Velmurugan Periasamy , pengjianhua , Pradeep Agrawal , sam rome , Colm O hEigeartaigh , Selvamohan Neethiraj , Ankita Sinha , Madhan Neethiraj , Don Bosco Durai Cc: Qiang Zhang , ranger Date: Wed, 26 Sep 2018 09:01:29 -0000 Message-ID: <20180926090129.31530.2042@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Qiang Zhang X-ReviewGroup: ranger X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/68849/ X-Sender: Qiang Zhang Reply-To: Qiang Zhang X-ReviewRequest-Repository: ranger --===============1255458758811470259== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68849/ ----------------------------------------------------------- Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Mehul Parikh, pengjianhua, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, sam rome, Venkat Ranganathan, and Velmurugan Periasamy. Bugs: RANGER-2235 https://issues.apache.org/jira/browse/RANGER-2235 Repository: ranger Description ------- On the Audit Admin tab page, if the user clicks to view the session details, it will jump to a new page, user cannot return to previous page. We need to click again to enter the Audit Admin tab page, and reselect the filter condition and the page number. Audit Login Sessions tab page has the same problem. Modify the login session detail page as a modal?the user can continue to view the current page after close the modal. Diffs ----- security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 697d33d9c security-admin/src/main/webapp/scripts/views/reports/LoginSessionDetail.js e92929a93 security-admin/src/main/webapp/templates/reports/LoginSessionDetail_tmpl.html b11fa83fb Diff: https://reviews.apache.org/r/68849/diff/1/ Testing ------- Thanks, Qiang Zhang --===============1255458758811470259==--