ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Csaba Koncz <csabako...@gmail.com>
Subject Re: Review Request 68770: RANGER-2220 minify JavaScript files during packaging
Date Wed, 26 Sep 2018 09:08:57 GMT


> On Sept. 24, 2018, 1:03 p.m., Nitin Galave wrote:
> > security-admin/pom.xml
> > Lines 562 (patched)
> > <https://reviews.apache.org/r/68770/diff/2/?file=2090907#file2090907line562>
> >
> >     maven build stuck after appyinng this patch
> 
> Csaba Koncz wrote:
>     The first maven build takes longer because nodejs needs to be downloaded by the frontend
plugin.
>     
>     Could you post the console output?
>     Can you locate the line belonging to the nodejs download?
>     
>     In my case, this is the command I issue:
>     
>     mvn package -DskipTests -pl security-admin -am
>     
>     And this is how the frontend plugin executions start: 
>     ...
>     [INFO]
>     [INFO] --- frontend-maven-plugin:1.6:install-node-and-npm (install node and npm)
@ security-admin-web ---
>     [INFO] Node v8.12.0 is already installed.
>     [INFO] NPM 6.4.1 is already installed.
>     [INFO]
>     ...
> 
> Nitin Galave wrote:
>     For compiling and packaging we use 
>     mvn clean compile package assembly:assembly install
>     and it excute the rat-plugin 
>     
>     
>     maven build success if we ignore rat-plugin in pom.xml
>     I think we should exclude npm and node_modeuls directory for rat-plugin (root dir
: pom.xml).

Oh, thank you. I overlooked the excludeSubProjects setting in the parent pom (https://github.com/apache/ranger/blob/master/pom.xml#L569).

This is a bit silly because now the files are checked twice for licenses during the verify
phase: both in the submodules and at the end by the parent module.
And the exclusions must contain wildcards so that they work even when evaluated in different
locations.

I updated the patch, the nodejs exclusions are in the parent pom now.
In the long run it might be worth setting excludeSubProjects=true and move the submodule-specific
rat exclusions to the sobmodule poms.


- Csaba


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68770/#review208940
-----------------------------------------------------------


On Sept. 26, 2018, 8:58 a.m., Csaba Koncz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68770/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2018, 8:58 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2220
>     https://issues.apache.org/jira/browse/RANGER-2220
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Maven build modified so that the admin UI JavaScript resources are concatenated/compressed
using the RequireJS Optimizer.
> During the packaging phase index.html is rewritten so that it loads the compressed JS
file instead of the JS source tree.
> 
> 
> Diffs
> -----
> 
>   pom.xml d8e3a5da9 
>   security-admin/.gitignore 5a3a67338 
>   security-admin/package-lock.json PRE-CREATION 
>   security-admin/package.json PRE-CREATION 
>   security-admin/pom.xml 84bbd6650 
>   security-admin/src/main/webapp/index.html 60ef5a75b 
>   security-admin/src/main/webapp/libs/bower/backbone-forms/js/bootstrap.js 276175505

>   security-admin/src/main/webapp/libs/bower/backbone.bootstrap-modal/js/backbone.bootstrap-modal.js
6cd05b03d 
>   security-admin/src/main/webapp/minify.build.js PRE-CREATION 
>   security-admin/src/main/webapp/scripts/Init.js 4493f62e0 
>   security-admin/src/main/webapp/scripts/Main.js d518afbf2 
> 
> 
> Diff: https://reviews.apache.org/r/68770/diff/3/
> 
> 
> Testing
> -------
> 
> Performed:
> 
> mvn package -pl security-admin -am
> cd security-admin/
> cd security-admin/target/security-admin-web-2.0.0-SNAPSHOT
> http-server
> # opened http://localhost:8080 and inspected browser network tab and console:
> # network tab lists only 26 requests
> # console contains no packaging related errors (it contains 4 errors due to missing backend
service)
> 
> 
> Thanks,
> 
> Csaba Koncz
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message