ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mehul Parikh <mehul.par...@freestoneinfotech.com>
Subject Re: Review Request 67782: RANGER-2144 - refactor DAO creation
Date Wed, 05 Sep 2018 12:20:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67782/#review208348
-----------------------------------------------------------



@Zsombor - your patch is not getting applied on master branch. Can you please rebase your
patch to latest master branch?

- Mehul Parikh


On Aug. 6, 2018, 7:44 p.m., Zsombor Gegesy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67782/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2018, 7:44 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2144
>     https://issues.apache.org/jira/browse/RANGER-2144
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Currently, RangerDaoManagerBase is used to construct new DAO instances, instead of relying
on Spring to provide one for it. This would reduce the code to write and run, and make it
less interdependent, and simplifies the tests, as less code would be needed to mock.
> 
> As RangerDaoManagerBase is used everywhere, and to avoid having huge patches, it would
be better do it in smaller steps.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 941691aaa 
>   security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java b304e3e99 
>   security-admin/src/main/java/org/apache/ranger/biz/RangerPolicyRetriever.java 3e291d50c

>   security-admin/src/main/java/org/apache/ranger/biz/RangerTagDBRetriever.java 789068fcb

>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 0773616f9 
>   security-admin/src/main/java/org/apache/ranger/biz/SessionMgr.java 4a426b78a 
>   security-admin/src/main/java/org/apache/ranger/biz/TagDBStore.java d29df930c 
>   security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 2a638f890 
>   security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java b1ea280c9 
>   security-admin/src/main/java/org/apache/ranger/common/StringUtil.java 82afa2708 
>   security-admin/src/main/java/org/apache/ranger/db/RangerDaoManager.java 2788a6109 
>   security-admin/src/main/java/org/apache/ranger/db/RangerDaoManagerBase.java da89e041c

>   security-admin/src/main/java/org/apache/ranger/db/XXAssetDao.java 1cd83badc 
>   security-admin/src/main/java/org/apache/ranger/db/XXPortalUserDao.java d383cf596 
>   security-admin/src/main/java/org/apache/ranger/db/XXResourceDao.java 24a0e63ef 
>   security-admin/src/main/java/org/apache/ranger/db/XXUserDao.java 58bf4d891 
>   security-admin/src/main/java/org/apache/ranger/patch/PatchMigration_J10002.java 0af7a1da2

>   security-admin/src/main/java/org/apache/ranger/patch/PatchTagModulePermission_J10005.java
6f9350da2 
>   security-admin/src/main/java/org/apache/ranger/rest/PublicAPIs.java 7df957973 
>   security-admin/src/main/java/org/apache/ranger/service/RangerPluginInfoService.java
2bbf0d413 
>   security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java a3ff825dd

>   security-admin/src/main/java/org/apache/ranger/service/RangerPolicyWithAssignedIdService.java
540a29eb2 
>   security-admin/src/main/java/org/apache/ranger/service/RangerServiceDefServiceBase.java
5cbe47ad3 
>   security-admin/src/main/java/org/apache/ranger/service/RangerServiceResourceService.java
d7256802a 
>   security-admin/src/main/java/org/apache/ranger/service/RangerTagDefService.java 82eb252e6

>   security-admin/src/main/java/org/apache/ranger/service/RangerTagResourceMapService.java
89c451ee2 
>   security-admin/src/main/java/org/apache/ranger/service/RangerTagService.java 28b9115fa

>   security-admin/src/main/java/org/apache/ranger/service/RangerTagServiceBase.java 2e2c04f47

>   security-admin/src/main/java/org/apache/ranger/service/UserService.java 9ca6a4fb3 
>   security-admin/src/main/java/org/apache/ranger/service/XModuleDefService.java d5ca38548

>   security-admin/src/main/java/org/apache/ranger/service/XPolicyService.java 066bc6ae7

>   security-admin/src/main/java/org/apache/ranger/service/XPortalUserService.java c96878d21

>   security-admin/src/main/java/org/apache/ranger/service/XResourceService.java b3e7bd7d7

>   security-admin/src/main/java/org/apache/ranger/service/XUgsyncAuditInfoService.java
7f3d0c70d 
>   security-admin/src/main/java/org/apache/ranger/service/XUserPermissionServiceBase.java
bc6c21eae 
>   security-admin/src/test/java/org/apache/ranger/biz/TestRangerBizUtil.java 22e290a66

>   security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java b0b011022

>   security-admin/src/test/java/org/apache/ranger/biz/TestUserMgr.java 202a113d8 
>   security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java 4f4298a95 
>   security-admin/src/test/java/org/apache/ranger/rest/TestPublicAPIs.java 2bf5ee6c9 
>   security-admin/src/test/java/org/apache/ranger/rest/TestUserREST.java 3c3051b39 
>   security-admin/src/test/java/org/apache/ranger/service/TestRangerServiceDefService.java
a36b19879 
>   security-admin/src/test/java/org/apache/ranger/service/TestRangerServiceDefServiceBase.java
74f1dd0c4 
>   security-admin/src/test/java/org/apache/ranger/service/TestRangerTagDefService.java
8f19ffd78 
>   security-admin/src/test/java/org/apache/ranger/service/TestRangerTagResourceMapService.java
27ec8e140 
>   security-admin/src/test/java/org/apache/ranger/service/TestRangerTagService.java 1175989e2

>   security-admin/src/test/java/org/apache/ranger/service/TestUserService.java c48739b94

> 
> 
> Diff: https://reviews.apache.org/r/67782/diff/2/
> 
> 
> Testing
> -------
> 
> Tested with unit tests and on a live cluster.
> 
> 
> Thanks,
> 
> Zsombor Gegesy
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message