From dev-return-19053-archive-asf-public=cust-asf.ponee.io@ranger.apache.org Thu Aug 30 19:46:28 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 67DE3180656 for ; Thu, 30 Aug 2018 19:46:28 +0200 (CEST) Received: (qmail 58998 invoked by uid 500); 30 Aug 2018 17:46:27 -0000 Mailing-List: contact dev-help@ranger.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ranger.apache.org Delivered-To: mailing list dev@ranger.apache.org Received: (qmail 58980 invoked by uid 99); 30 Aug 2018 17:46:26 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Aug 2018 17:46:26 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 72015C9382; Thu, 30 Aug 2018 17:46:26 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.95 X-Spam-Level: X-Spam-Status: No, score=0.95 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id jroWb2ZF2cjW; Thu, 30 Aug 2018 17:46:25 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 3090C5F30E; Thu, 30 Aug 2018 17:46:25 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C3564E0110; Thu, 30 Aug 2018 17:46:24 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id B0507C40183; Thu, 30 Aug 2018 17:46:24 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4036890658873624064==" MIME-Version: 1.0 Subject: Re: Review Request 68211: RANGER-2157 Add NiFi Registry service definition and NiFiRegistryClient From: Ramesh Mani To: "ijokarumawak@gmail.com Koji" , Ramesh Mani , ranger Date: Thu, 30 Aug 2018 17:46:24 -0000 Message-ID: <20180830174624.31612.6418@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated In-Reply-To: <20180817105556.27877.1170@reviews-vm2.apache.org> X-ReviewGroup: ranger X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/68211/ X-Sender: Ramesh Mani X-ReviewBoard-ShipIt: 1 References: <20180817105556.27877.1170@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryAuthType.java X-ReviewBoard-Diff-For: plugin-nifi-registry/src/test/java/org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryConnectionMgr.java X-ReviewBoard-Diff-For: plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/RangerServiceNiFiRegistry.java X-ReviewBoard-Diff-For: plugin-nifi-registry/pom.xml X-ReviewBoard-Diff-For: plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryConfigs.java X-ReviewBoard-Diff-For: plugin-nifi-registry/.gitignore X-ReviewBoard-Diff-For: plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryClient.java X-ReviewBoard-Diff-For: agents-common/src/main/resources/service-defs/ranger-servicedef-nifi-registry.json X-ReviewBoard-Diff-For: plugin-nifi-registry/src/test/resources/resources-response.json X-ReviewBoard-Diff-For: plugin-nifi-registry/src/test/java/org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryClient.java X-ReviewBoard-Diff-For: plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryConnectionMgr.java X-ReviewBoard-ShipIt-Only: 1 Reply-To: Ramesh Mani X-ReviewRequest-Repository: ranger Sender: Ramesh Mani --===============4036890658873624064== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68211/#review208139 ----------------------------------------------------------- Ship it! Ship It! - Ramesh Mani On Aug. 17, 2018, 10:55 a.m., ijokarumawak@gmail.com Koji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68211/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2018, 10:55 a.m.) > > > Review request for ranger. > > > Bugs: RANGER-2157 > https://issues.apache.org/jira/browse/RANGER-2157 > > > Repository: ranger > > > Description > ------- > > Adding NiFi Registry service. NiFi Registry is a sub-project of NiFi. > > > Diffs > ----- > > agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 5e74da85a > agents-common/src/main/resources/service-defs/ranger-servicedef-nifi-registry.json PRE-CREATION > plugin-nifi-registry/.gitignore PRE-CREATION > plugin-nifi-registry/pom.xml PRE-CREATION > plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/RangerServiceNiFiRegistry.java PRE-CREATION > plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryAuthType.java PRE-CREATION > plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryClient.java PRE-CREATION > plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryConfigs.java PRE-CREATION > plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryConnectionMgr.java PRE-CREATION > plugin-nifi-registry/src/test/java/org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryClient.java PRE-CREATION > plugin-nifi-registry/src/test/java/org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryConnectionMgr.java PRE-CREATION > plugin-nifi-registry/src/test/resources/resources-response.json PRE-CREATION > pom.xml 472199d5d > src/main/assembly/admin-web.xml d0f354520 > > > Diff: https://reviews.apache.org/r/68211/diff/3/ > > > Testing > ------- > > Tested on local machine. > > In order to get NiFi Registry for integration tests, NiFi Registry needs to be built manually as the change is not released at NiFi Registry project yet. Please check [NiFi Registry Pull Request 131 for NIFIREG-186](https://github.com/apache/nifi-registry/pull/131) to do so, especially this [README](https://github.com/apache/nifi-registry/blob/29239be99a5f6275060ecbdcb16ae9a8e7abef86/nifi-registry-extensions/nifi-registry-ranger-extension/README.md) file should be a starting point. > > > Thanks, > > ijokarumawak@gmail.com Koji > > --===============4036890658873624064==--